Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rpUfj-0070oi-Ce for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Mar 2024 14:54:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rpUfh-00FgaS-Vj for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Mar 2024 14:54:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rpUfh-00FgZr-M5 for pgsql-hackers@lists.postgresql.org; Wed, 27 Mar 2024 14:54:33 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rpUfb-006nzo-UH for pgsql-hackers@postgresql.org; Wed, 27 Mar 2024 14:54:33 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 42REs5us3304323; Wed, 27 Mar 2024 10:54:05 -0400 From: Tom Lane To: Michael Banck cc: Laurenz Albe , Nathan Bossart , vignesh C , "Kumar, Sachin" , Robins Tharakan , Jan Wieck , Bruce Momjian , Andrew Dunstan , Magnus Hagander , Peter Eisentraut , "pgsql-hackers@postgresql.org" Subject: Re: pg_upgrade failing for 200+ million Large Objects In-reply-to: <6603e4e0.500a0220.a557f.4f39@mx.google.com> References: <83D44BE5-0088-4D41-8AE6-20A05D026F46@amazon.com> <81D13E16-BA04-43CF-9B89-B8924300B211@amazon.com> <240D05EC-8B28-4112-BEAB-85ECBAF3F871@amazon.com> <2055911.1702258962@sss.pgh.pa.us> <557FD681-3929-44A1-87B2-6B5E10C4A66B@amazon.com> <842242.1706287466@sss.pgh.pa.us> <4a3ebf7d81bfc6dd4d545e5b27d6e8f6c32d8937.camel@cybertec.at> <3023817.1710629175@sss.pgh.pa.us> <6603e4e0.500a0220.a557f.4f39@mx.google.com> Comments: In-reply-to Michael Banck message dated "Wed, 27 Mar 2024 10:20:31 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3304321.1711551245.1@sss.pgh.pa.us> Date: Wed, 27 Mar 2024 10:54:05 -0400 Message-ID: <3304322.1711551245@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Michael Banck writes: > What is the status of this? In the commitfest, this patch is marked as > "Needs Review" with Nathan as reviewer - Nathan, were you going to take > another look at this or was your mail from January 12th a full review? In my mind the ball is in Nathan's court. I feel it's about committable, but he might not agree. > Also, is there a chance this is going to be back-patched? No chance of that I'm afraid. The patch bumps the archive version number, because it creates TOC entries that older pg_restore would not know what to do with. We can't put that kind of compatibility break into stable branches. regards, tom lane