Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hkZNZ-000541-Qu for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Jul 2019 19:32:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hkZNY-0003rb-Hg for pgsql-hackers@arkaria.postgresql.org; Mon, 08 Jul 2019 19:32:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hkZNY-0003rU-2k for pgsql-hackers@lists.postgresql.org; Mon, 08 Jul 2019 19:32:48 +0000 Received: from cyclops.postgrespro.ru ([93.174.131.138] helo=mail.postgrespro.ru) by makus.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hkZNU-00042G-CH for pgsql-hackers@postgresql.org; Mon, 08 Jul 2019 19:32:46 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 3338F21C22D5; Mon, 8 Jul 2019 22:32:41 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[] autolearn=unavailable Received: from [192.168.28.110] (unknown [192.168.28.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id 1BFB221C06A4; Mon, 8 Jul 2019 22:32:40 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1562614361; bh=CwKCKNiz+Ecm0mUbOwzWZtJrryFVB5TkrEQKIVTzZIY=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=VbtLmA4XeN/lcj2fmDDWqO5Rzkjy7tp1OmmLtRuT9kRkT+Nq9E3coPS4jBhA5eCvT +JwAVhz+Yox6aadHZ9WkxWr7WydFf9V/kfCy9RqWaWtcIViFry3HMOVUAUqCrGyb/z hUiD2VXycqeZQHfvD9of1ImQth+PeSbzN/TzLOWE= Subject: Re: [HACKERS] Cached plans and statement generalization To: Thomas Munro Cc: PostgreSQL Hackers References: <9A6E5062D5D4DB458C80C2B2920BD71D5C5111@g01jpexmbkw23> <3a054e51-448e-a66d-074e-099a3f3f62b2@postgrespro.ru> <9A6E5062D5D4DB458C80C2B2920BD71D5ECEB5@g01jpexmbkw23> <9A6E5062D5D4DB458C80C2B2920BD71D610148@g01jpexmbkw23> <6ea1db86-b300-b57c-0f9d-a55dd3966175@postgrespro.ru> <9A6E5062D5D4DB458C80C2B2920BD71D6820CB@g01jpexmbkw23> <554d0730-f6fc-d1be-fe78-e63973ec621f@postgrespro.ru> <35be0423-36bc-cadc-bef8-02d475751f7d@postgrespro.ru> <7603a101-6b79-2328-2b4b-3bc3217992e5@postgrespro.ru> From: Konstantin Knizhnik Message-ID: <3304c34b-4a9c-909c-4ee1-d8e7f6dcb2de@postgrespro.ru> Date: Mon, 8 Jul 2019 22:32:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 08.07.2019 2:23, Thomas Munro wrote: > On Tue, Jul 2, 2019 at 3:29 AM Konstantin Knizhnik > wrote: >> Attached please find rebased version of the patch. >> Also this version can be found in autoprepare branch of this repository >> https://github.com/postgrespro/postgresql.builtin_pool.git >> on github. > Thanks. I haven't looked at the code but this seems like interesting > work and I hope it will get some review. I guess this is bound to use > a lot of memory. I guess we'd eventually want to figure out how to > share the autoprepared plan cache between sessions, which is obviously > a whole can of worms. > > A couple of trivial comments with my CF manager hat on: > > 1. Can you please fix the documentation? It doesn't build. > Obviously reviewing the goals, design and implementation are more > important than the documentation at this point, but if that is fixed > then the CF bot will be able to run check-world every day and we might > learn something about the code. > 2. Accidental editor junk included: src/include/catalog/pg_proc.dat.~1~ Sorry, are you tests autoprepare-16.patch I have sent in the last e-mail? I can not reproduce the problem with building documentation: knizhnik@xps:~/postgresql/doc$ make make -C ../src/backend generated-headers make[1]: Entering directory '/home/knizhnik/postgresql/src/backend' make -C catalog distprep generated-header-symlinks make[2]: Entering directory '/home/knizhnik/postgresql/src/backend/catalog' make[2]: Nothing to be done for 'distprep'. make[2]: Nothing to be done for 'generated-header-symlinks'. make[2]: Leaving directory '/home/knizhnik/postgresql/src/backend/catalog' make -C utils distprep generated-header-symlinks make[2]: Entering directory '/home/knizhnik/postgresql/src/backend/utils' make[2]: Nothing to be done for 'distprep'. make[2]: Nothing to be done for 'generated-header-symlinks'. make[2]: Leaving directory '/home/knizhnik/postgresql/src/backend/utils' make[1]: Leaving directory '/home/knizhnik/postgresql/src/backend' make -C src all make[1]: Entering directory '/home/knizhnik/postgresql/doc/src' make -C sgml all make[2]: Entering directory '/home/knizhnik/postgresql/doc/src/sgml' /usr/bin/xmllint --path . --noout --valid postgres.sgml /usr/bin/xsltproc --path . --stringparam pg.version '12devel' stylesheet.xsl postgres.sgml cp ./stylesheet.css html/ touch html-stamp /usr/bin/xmllint --path . --noout --valid postgres.sgml /usr/bin/xsltproc --path . --stringparam pg.version '12devel' stylesheet-man.xsl postgres.sgml touch man-stamp make[2]: Leaving directory '/home/knizhnik/postgresql/doc/src/sgml' make[1]: Leaving directory '/home/knizhnik/postgresql/doc/src' Also autoporepare-16.patch doesn't include any junk src/include/catalog/pg_proc.dat.~1~