public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Richard Guo <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Remove some redundant set_cheapest() calls
Date: Wed, 27 Mar 2024 10:59:06 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAMbWs4_zhKyQaxOFe8mViY_fsi9rO=wsALijRg+PvXvsr9=U+w@mail.gmail.com>
References: <CAMbWs4-KFEU_fDuJPNCOkUu3rwvZvKBEytkd9VrM4kH4-2h1CQ@mail.gmail.com>
	<[email protected]>
	<CAMbWs4_zhKyQaxOFe8mViY_fsi9rO=wsALijRg+PvXvsr9=U+w@mail.gmail.com>

Richard Guo <[email protected]> writes:
> On Wed, Mar 27, 2024 at 4:06 AM Tom Lane <[email protected]> wrote:
>> I'm less convinced about changing this.  I'd rather keep it consistent
>> with mark_dummy_rel.

> Hm, I wonder if we should revise the comment there that states "but not
> when called from elsewhere", as it does not seem to be true.

I'd be okay with wording like "This is redundant in current usage
because set_rel_pathlist will do it later, but it's cheap so we keep
it for consistency with mark_dummy_rel".  What do you think?

			regards, tom lane

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Remove some redundant set_cheapest() calls
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox