From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Corey Huinker <corey.huinker@gmail.com>,
        Andrew Dunstan <andrew@dunslane.net>,
        Nikita Glukhov <n.gluhov@postgrespro.ru>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Error-safe user functions
In-reply-to: 
 <CA+TgmoZHVbfhv2+9G=DDNAMDtjEFX3CF684Sw+8Dh95qtqudwg@mail.gmail.com>
References: <3bbbb0df-7382-bf87-9737-340ba096e034@postgrespro.ru>
 <3190059.1665164276@sss.pgh.pa.us>
 <57b7cc2e-1215-3f43-84e4-6d9f8ad575df@dunslane.net>
 <CADkLM=djieyppZpKgveeDdt3QYLt+XQGHzpoa+Sd_Lwa5dDTWA@mail.gmail.com>
 <3049337.1669008405@sss.pgh.pa.us>
 <469338a3-da38-160f-23b9-813c261bc1d6@dunslane.net>
 <1677334.1669918475@sss.pgh.pa.us>
 <CA+TgmoY44nbY6Z7zbnQ1VwgDu79DbOHmh4o8K9cBu0OeC2Hndw@mail.gmail.com>
 <1695760.1669923671@sss.pgh.pa.us>
 <CA+TgmobpfOx0WT+ZG71eB5=JrKUi-VX7FwsVF6E8ps1WfKYYcQ@mail.gmail.com>
 <1703871.1669927782@sss.pgh.pa.us>
 <CA+TgmoaxLcxpLmFJ=QiOThfPRGLhRH+o2XZmVie2KOk5TKGbKg@mail.gmail.com>
 <1721519.1669934025@sss.pgh.pa.us>
 <CA+TgmoZ5tQz4sZfXOAK-wx7e2d2+pGg4EEc1TA4sb9gNMjm4Fw@mail.gmail.com>
 <1925585.1669990324@sss.pgh.pa.us>
 <02cf2f81-a776-37ff-291c-100480722a5c@dunslane.net>
 <2503569.1670104001@sss.pgh.pa.us>
 <CADkLM=end5RBrsQMfyB8VxvOmu5AZzsffQbDJge3TjtkxUGkEQ@mail.gmail.com>
 <CA+Tgmoa-A61npwUqzGs7J-tt6RaCwOx-p=cx+Xss=fyjeSTDew@mail.gmail.com> <330!
 4244.1670256567@sss.pgh.pa.us>
 <CA+TgmoZHVbfhv2+9G=DDNAMDtjEFX3CF684Sw+8Dh95qtqudwg@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Mon, 05 Dec 2022 11:20:02 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3311161.1670260197.1@sss.pgh.pa.us>
Date: Mon, 05 Dec 2022 12:09:57 -0500
Message-ID: <3311162.1670260197@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3311162.1670260197%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Mon, Dec 5, 2022 at 11:09 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> efeedback?  But TBH I do not think any of these are better than ereturn.

> I do. Having a macro name that is "return" plus one character is going
> to make people think that it returns.

But it does return, or at least you need to code on the assumption
that it will.  (The cases where it doesn't aren't much different
from any situation where a called subroutine unexpectedly throws
an error.  Callers typically don't have to consider that.)

			regards, tom lane