pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedTime to backpatch config/ax_pthread.m4 changes?
3+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2018-11-19 df303aff66 Update config/ax_pthread.m4 to latest upstream version.
2018-11-19 100535bba0 7c86b94311 Back-patch updated thread flags tests into 9.4 and 9.5.
* Time to backpatch config/ax_pthread.m4 changes?
@ 2018-11-19 17:12 Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 3+ messages in thread
From: Tom Lane @ 2018-11-19 17:12 UTC (permalink / raw)
To: pgsql-hackers@lists.postgresql.org; +Cc: Heikki Linnakangas <hlinnaka@iki.fi>
I noticed that buildfarm member quokka (RHEL 7 / ppc64) has started
failing configure in the 9.4 and 9.5 branches. This appears to be
because configure is not detecting the need to use "-pthread" to get
thread-related functions. We didn't change anything in that area
ourselves, so I'm guessing that this is a result of a platform update,
which more than likely is going to start affecting other users before
long, so we'd better fix it.
It looks to me like the reason it's okay in 9.6 and up is
commit e97af6c8b ("Replace our hacked version of ax_pthread.m4 with
latest upstream version") plus a few followup fixes. I propose to
back-patch those into 9.5 and 9.4. Heikki had attempted to back-patch
into 9.5 originally, but gave up when the followup fixes seemed to
be getting out of hand --- but there weren't really that many.
Anyway, now that that code has been stable for several years, I see
little reason not to back-patch it.
regards, tom lane
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Time to backpatch config/ax_pthread.m4 changes?
@ 2018-11-19 17:42 Heikki Linnakangas <hlinnaka@iki.fi>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 3+ messages in thread
From: Heikki Linnakangas @ 2018-11-19 17:42 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; pgsql-hackers@lists.postgresql.org
On 19/11/2018 19:12, Tom Lane wrote:
> I noticed that buildfarm member quokka (RHEL 7 / ppc64) has started
> failing configure in the 9.4 and 9.5 branches. This appears to be
> because configure is not detecting the need to use "-pthread" to get
> thread-related functions. We didn't change anything in that area
> ourselves, so I'm guessing that this is a result of a platform update,
> which more than likely is going to start affecting other users before
> long, so we'd better fix it.
>
> It looks to me like the reason it's okay in 9.6 and up is
> commit e97af6c8b ("Replace our hacked version of ax_pthread.m4 with
> latest upstream version") plus a few followup fixes. I propose to
> back-patch those into 9.5 and 9.4. Heikki had attempted to back-patch
> into 9.5 originally, but gave up when the followup fixes seemed to
> be getting out of hand --- but there weren't really that many.
> Anyway, now that that code has been stable for several years, I see
> little reason not to back-patch it.
Makes sense.
It would be nice to pick the latest version from the authoritative
source (https://www.gnu.org/software/autoconf-archive/ax_pthread.html),
while we're at it. I picked a draft version back then, before it was
committed to the main branch. Although, if we do that, then the argument
that the code's been stable for several years doesn't apply anymore...
- Heikki
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Time to backpatch config/ax_pthread.m4 changes?
@ 2018-11-19 17:48 Tom Lane <tgl@sss.pgh.pa.us>
parent: Heikki Linnakangas <hlinnaka@iki.fi>
0 siblings, 0 replies; 3+ messages in thread
From: Tom Lane @ 2018-11-19 17:48 UTC (permalink / raw)
To: Heikki Linnakangas <hlinnaka@iki.fi>; +Cc: pgsql-hackers@lists.postgresql.org
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 19/11/2018 19:12, Tom Lane wrote:
>> It looks to me like the reason it's okay in 9.6 and up is
>> commit e97af6c8b ("Replace our hacked version of ax_pthread.m4 with
>> latest upstream version") plus a few followup fixes. I propose to
>> back-patch those into 9.5 and 9.4. Heikki had attempted to back-patch
>> into 9.5 originally, but gave up when the followup fixes seemed to
>> be getting out of hand --- but there weren't really that many.
>> Anyway, now that that code has been stable for several years, I see
>> little reason not to back-patch it.
> Makes sense.
> It would be nice to pick the latest version from the authoritative
> source (https://www.gnu.org/software/autoconf-archive/ax_pthread.html),
> while we're at it. I picked a draft version back then, before it was
> committed to the main branch. Although, if we do that, then the argument
> that the code's been stable for several years doesn't apply anymore...
Hm. I'll check that, but I'm inclined to just make any change like that
in HEAD, since we aren't aware of live bugs it would fix.
regards, tom lane
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2018-11-19 17:48 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-11-19 17:12 Time to backpatch config/ax_pthread.m4 changes? Tom Lane <tgl@sss.pgh.pa.us>
2018-11-19 17:42 ` Heikki Linnakangas <hlinnaka@iki.fi>
2018-11-19 17:48 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox