From: Tom Lane <tgl@sss.pgh.pa.us>
To: Vallimaharajan G <vallimaharajan.gs@zohocorp.com>
cc: "pgsql-hackers" <pgsql-hackers@postgresql.org>
Subject: Re: Query Regarding frame options initialization in Window aggregate state
In-reply-to: <18e7f2a5167.fe36253866818.977923893562469143@zohocorp.com>
References: <18e7f2a5167.fe36253866818.977923893562469143@zohocorp.com>
Comments: In-reply-to Vallimaharajan G <vallimaharajan.gs@zohocorp.com>
	message dated "Wed, 27 Mar 2024 14:37:43 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3320046.1711558608.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 27 Mar 2024 12:56:48 -0400
Message-ID: <3320047.1711558608@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3320047.1711558608%40sss.pgh.pa.us>
Precedence: bulk

Vallimaharajan G <vallimaharajan.gs@zohocorp.com> writes:
> I am currently referring to the Postgres source code (psql (PostgreSQL) =
14.3) and came across a particular section related to window aggregate ini=
tialization that has left me with a question. Specifically, I noticed a co=
nditional case in the initialization of per aggregate (initialize_peraggre=
gate in nodeWindowAgg.c) where the winstate frameOptions is being checked,=
 but it appears that frameOptions is not set before this conditional case.

You are right, and that's a bug.  It's not of major consequence ---
it would just cause us to set up for moving-aggregate mode when
we won't ever actually move the frame head -- but it's at least a
little bit inefficient.

While I'm looking at it, there's a pretty obvious typo in the
adjacent comment:

- * and collect the right set of fields from the pg_attribute entry.
+ * and collect the right set of fields from the pg_aggregate entry.

			regards, tom lane