To: pgsql-hackers@postgresql.org, David Zhang <david.zhang@highgo.ca>
From: David Zhang <david.zhang@highgo.ca>
Message-ID: <332c47fa-d951-7574-b5cc-a8f7f7201202@highgo.ca>
Subject: ERROR: invalid input syntax for type circle
Date: Mon, 6 Apr 2020 14:12:38 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0)
 Gecko/20100101 Thunderbird/68.6.0
MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="------------427340E4B6F024FAEDB426D5"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------427340E4B6F024FAEDB426D5
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Hi,

I got an error when I was trying to insert a circle using the syntax=20
(the 3rd one) specified in the latest document.

https://www.postgresql.org/docs/current/datatype-geometric.html#DATATYPE-CI=
RCLE
< ( x , y ) , r >
( ( x , y ) , r )
 =C2=A0 ( x , y ) , r
 =C2=A0=C2=A0=C2=A0 x , y=C2=A0=C2=A0 , r

Here is how to reproduce it.

CREATE TABLE tbl_circle(id serial PRIMARY KEY, a circle);
INSERT INTO tbl_circle(a) VALUES('( 1 , 1 ) , 5'::circle );

ERROR:=C2=A0 invalid input syntax for type circle: "( 1 , 1 ) , 5"
LINE 1: INSERT INTO tbl_circle(a) VALUES('( 1 , 1 ) , 5'::circle );

I made a little change in the "circle_in" function, and then I can enter=20
a circle using the 3rd way.

INSERT INTO tbl_circle(a) VALUES('( 1 , 1 ) , 5'::circle );
INSERT 0 1

The fix does generate the same output as the other three ways.

INSERT INTO tbl_circle(a) VALUES( '< ( 1 , 1 ) , 5 >'::circle );
INSERT INTO tbl_circle(a) VALUES( '( ( 1 , 1 ) , 5 )'::circle );
INSERT INTO tbl_circle(a) VALUES( '1 , 1 , 5'::circle );

select * from tbl_circle;
 =C2=A0id |=C2=A0=C2=A0=C2=A0=C2=A0 a
----+-----------
 =C2=A0 1 | <(1,1),5>
 =C2=A0 2 | <(1,1),5>
 =C2=A0 3 | <(1,1),5>
 =C2=A0 4 | <(1,1),5>
(4 rows)

Sor far, no error found during the "make check".

The patch based on tag "REL_12_2" is attached.

--=20
David

Software Engineer
Highgo Software Inc. (Canada)
www.highgo.ca

--------------427340E4B6F024FAEDB426D5
Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0";
 name="circle-in-input-format-fix.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="circle-in-input-format-fix.patch"

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9nZW9fb3BzLmMgYi9zcmMvYmFj
a2VuZC91dGlscy9hZHQvZ2VvX29wcy5jCmluZGV4IDM3Mzc4NGZjYzEuLjZlZmQ1YmMxZjIg
MTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9nZW9fb3BzLmMKKysrIGIvc3Jj
L2JhY2tlbmQvdXRpbHMvYWR0L2dlb19vcHMuYwpAQCAtNDUyOCw3ICs0NTI4LDcgQEAgY2ly
Y2xlX2luKFBHX0ZVTkNUSU9OX0FSR1MpCiAKIAl3aGlsZSAoZGVwdGggPiAwKQogCXsKLQkJ
aWYgKCgqcyA9PSBSREVMSU0pIHx8ICgoKnMgPT0gUkRFTElNX0MpICYmIChkZXB0aCA9PSAx
KSkpCisJCWlmICgoKnMgPT0gUkRFTElNKSB8fCAoKCgqcyA9PSBSREVMSU1fQykgfHwgKCpz
ID09ICdcMCcpKSAmJiAoZGVwdGggPT0gMSkpKQogCQl7CiAJCQlkZXB0aC0tOwogCQkJcysr
Owo=
--------------427340E4B6F024FAEDB426D5--