From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Nathan Bossart <nathandbossart@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: improving user.c error messages
In-reply-to: <CA+TgmoY-CCk4hp5eArrFM6M8G6xLbbt9e6OLsaZ5dC=MB049XQ@mail.gmail.com>
References: <CA+TgmoYwTFTQR0+qe+_asEvv2wqQL+0JCyexgVy2Ct31+rCb7w@mail.gmail.com> <CA+TgmobX=LHg_J5aT=0pi9gJy=JdtrUVGAu0zhr-i5v5nNbJDg@mail.gmail.com> <20230118231749.GA3790025@nathanxps13> <CA+TgmobVS6OMZMpp9Pus3U680ZY-v5Nao8bmx2ph+UTDPiQqNQ@mail.gmail.com> <20230126002251.GA1506128@nathanxps13> <9811affe-6755-2618-001b-46d6218e5463@enterprisedb.com> <CA+TgmoY-CCk4hp5eArrFM6M8G6xLbbt9e6OLsaZ5dC=MB049XQ@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Fri, 27 Jan 2023 08:31:32 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3335490.1674836233.1@sss.pgh.pa.us>
Date: Fri, 27 Jan 2023 11:17:13 -0500
Message-ID: <3335491.1674836233@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3335491.1674836233%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> I almost hate to bring this up since I'm not sure how far we want to
> go down this rat hole, but what should be our policy about mentioning
> superuser? I don't think we're entirely consistent right now, and I'm
> not sure whether every error message needs to mention that if you were
> the superuser you could do everything. Is that something we should
> mention always, never, or in some set of circumstances?

Good point.  My vote is for standardizing on *not* mentioning it.
Error messages should say "you need privilege X".  That is not
the place to go into all the ways you could hold privilege X
(one of which is being superuser).

			regards, tom lane