From: Tom Lane <tgl@sss.pgh.pa.us>
To: "'alvherre@alvh.no-ip.org'" <alvherre@alvh.no-ip.org>
cc: "iwata.aya@fujitsu.com" <iwata.aya@fujitsu.com>,
        "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>,
        "'Kyotaro Horiguchi'" <horikyota.ntt@gmail.com>,
        "k.jamison@fujitsu.com" <k.jamison@fujitsu.com>,
        "pgsql-hackers@lists.postgresql.org"
 <pgsql-hackers@lists.postgresql.org>,
        Andrew Dunstan <andrew@dunslane.net>
Subject: Re: libpq debug log
In-reply-to: <20210331220920.GA23882@alvherre.pgsql>
References: <20210331220920.GA23882@alvherre.pgsql>
Comments: In-reply-to "'alvherre@alvh.no-ip.org'" <alvherre@alvh.no-ip.org>
	message dated "Wed, 31 Mar 2021 19:09:20 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3336854.1617229186.1@sss.pgh.pa.us>
Date: Wed, 31 Mar 2021 18:19:46 -0400
Message-ID: <3336855.1617229186@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3336855.1617229186%40sss.pgh.pa.us>
Precedence: bulk

"'alvherre@alvh.no-ip.org'" <alvherre@alvh.no-ip.org> writes:
> On 2021-Mar-31, Tom Lane wrote:
>> So for some reason, opening the trace file fails.
>> (I wonder why we don't see an error message for this though.)

> .. oh, I think we forgot to set conn->Pfdebug = NULL when creating the
> connection.  So when we do PQtrace(), the first thing it does is
> PQuntrace(), and then that tries to do fflush(conn->Pfdebug) ---> crash.
> So this should fix it.

Nope, see the MemSet a few lines further up.  This change seems like
good style, but it won't fix anything --- else we'd have been
having issues with the pre-existing trace logic.

What I suspect is some Windows dependency in the way that
001_libpq_pipeline.pl is setting up the trace output files.
cc'ing Andrew to see if he has any ideas.

			regards, tom lane