From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: "David E. Wheeler" <david@justatheory.com>,
        Mankirat Singh <mankiratsingh1315@gmail.com>, pg@bowt.ie,
        andrew@dunslane.net, pgsql-hackers@lists.postgresql.org
Subject: Re: abi-compliance-check failure due to recent changes to
 pg_{clear,restore}_{attribute,relation}_stats()
In-reply-to: <aPZnY0Icgw1RGaGP@nathan>
References: <aPKFmL8VjOKNVLcw@nathan> <1723302.1760726712@sss.pgh.pa.us>
 <aPKUzk2xFhZBbWmz@nathan>
 <78B81B37-9F27-4085-92DA-6B50DFC24361@justatheory.com>
 <CAOtk82QCHhWwO=zB-KFYch3JLf8Si4Bk77R_0cgsHjkwuhR9Vg@mail.gmail.com>
 <1957147.1760800489@sss.pgh.pa.us>
 <17DB0A6A-C967-48A8-B1C0-9A4F31C4F8EF@justatheory.com>
 <CAOtk82T=OO3e=SYPyHZq50wfyt569E6t=ee4b7va2y08M+a0SQ@mail.gmail.com>
 <F6567E02-23FD-455C-95D2-5CB076BC4E65@justatheory.com>
 <230647.1760971159@sss.pgh.pa.us> <aPZnY0Icgw1RGaGP@nathan>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Mon, 20 Oct 2025 11:46:27 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <334459.1760980024.1@sss.pgh.pa.us>
Date: Mon, 20 Oct 2025 13:07:04 -0400
Message-ID: <334460.1760980024@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/334460.1760980024%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> Thanks.  Here's a new patch set.  The v18 patch is just an update to the
> .abi-compliance-history file that Tom committed.  The master patch adds
> instructions for generating the file to RELEASE_NOTES.

I'd tend to s/placate/control/, otherwise the proposed wording in the
file looks good.  I doubt we really need a script to generate the
file in the first place -- why wouldn't copying another branch's
boilerplate be good enough?  If you're set on having a script,
at least make it pre-fill the initial entry.  (Using branch HEAD
ought to be good enough for that.)

> I imagine we'll
> want to add .abi-compliance-history files for the back-branches, too
> (except for perhaps v13, which is about to go out of support in a couple
> weeks).

Agreed, but let's get v18 in shape first.  I imagine the back branches
will require some effort to fill in the correct reference commits.
I was expecting we'd commit initial values pointing at the .0 releases
and then seeing what the ABI checker moans about in each branch ...

			regards, tom lane