From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Postgres hackers <pgsql-hackers@lists.postgresql.org>,
        "Drouvot,
    Bertrand" <bdrouvot@amazon.com>
Subject: Re: Generating code for query jumbling through gen_node_support.pl
In-reply-to: <Y9i3+PdW+REPD2oE@paquier.xyz>
References: <Y8eZ9/3STyhF57RV@paquier.xyz>
 <50b571dc-e0c0-22be-9803-4a3480d2e792@enterprisedb.com>
 <Y8oaA5Vxnr4rzEDJ@paquier.xyz>
 <e4d61d52-4992-d190-b5ad-48c6c752942c@enterprisedb.com>
 <Y8tdmPlzFyNcrPR3@paquier.xyz>
 <bf604c8d-b6e9-284b-327a-cac8417a74e8@enterprisedb.com>
 <Y8+BdCOjxykre5es@paquier.xyz>
 <9695f035-0f2b-92b9-deed-0b7e5bb7e4e0@enterprisedb.com>
 <Y9M+C2obzgRnXPNd@paquier.xyz>
 <268fd337-8bb7-92e6-0da2-416c022c11f3@enterprisedb.com>
 <Y9i3+PdW+REPD2oE@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Tue, 31 Jan 2023 15:40:56 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3344826.1675809127.1@sss.pgh.pa.us>
Date: Tue, 07 Feb 2023 17:32:07 -0500
Message-ID: <3344827.1675809127@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3344827.1675809127%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> With all that in mind, I have spent my day polishing that and doing a
> close lookup, and the patch has been applied.  Thanks a lot!

I have just noticed that this patch is generating useless jumbling
code for node types such as Path nodes and other planner infrastructure
nodes.  That no doubt contributes to the miserable code coverage rating
for queryjumblefuncs.*.c, which have enough dead lines to drag down the
overall rating for all of backend/nodes/.  Shouldn't a little more
attention have been paid to excluding entire node classes if they can
never appear in Query?

			regards, tom lane