public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Thomas Munro <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Tree-walker callbacks vs -Wdeprecated-non-prototype
Date: Mon, 19 Sep 2022 10:00:05 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+hUKG+FVo16ReJa5qWU84h4wpN7w32FG1PUWDcsgQviL-2QEA@mail.gmail.com>
References: <CA+hUKGKpHPDTv67Y+s6yiC8KH5OXeDg6a-twWo_xznKTcG0kSA@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<CA+hUKGK=xCw9_V7tCMvpT5D83AH8ArotTw3W4s70Vhqr7VgZkg@mail.gmail.com>
<CA+hUKG+FVo16ReJa5qWU84h4wpN7w32FG1PUWDcsgQviL-2QEA@mail.gmail.com>
Thomas Munro <[email protected]> writes:
> On Mon, Sep 19, 2022 at 10:16 AM Thomas Munro <[email protected]> wrote:
>> Huh... wouldn't systems that pass arguments right-to-left on the stack
>> receive NULL for node? That'd include the SysV i386 convention used
>> on Linux, *BSD etc. But that can't be right or we'd know about it...
> I take that back after looking up some long forgotten details; it
> happily ignores extra arguments.
Yeah; the fact that no one has complained in several years seems to
indicate that there's not a problem on supported platforms. Still,
unlike the quibbles over whether char and struct pointers are the
same, it seems clear that this is the sort of inconsistency that
C2x wants to forbid, presumably in the name of making the world
safe for more-efficient function calling code. So I think we'd
better go fix ExecShutdownNode before somebody breaks it.
Whichever way we jump on the tree-walker API changes, those won't
be back-patchable. I think the best we can do for the back branches
is add a configure test to use -Wno-deprecated-non-prototype
if available. But the ExecShutdownNode change could be back-patched,
and I'm leaning to doing so even though that breakage is just
hypothetical today.
regards, tom lane
view thread (19+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: Tree-walker callbacks vs -Wdeprecated-non-prototype
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox