From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
cc: Michael Paquier <michael@paquier.xyz>, Joe Conway <mail@joeconway.com>,
        Joshua Brindle <joshua.brindle@crunchydata.com>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: use has_privs_of_role() for pg_hba.conf
In-reply-to: <20221007194430.GA550749@nathanxps13>
References: <20220401220648.GA615994@nathanxps13>
 <CAGB+Vh5epaDEu7aRokcuc_a7yG0B49u9ebpdViJHpyFN-exJtQ@mail.gmail.com>
 <20220404142551.GB663209@nathanxps13> <Yz6NRrfd7n2AXoHh@paquier.xyz>
 <491dba16-55df-d5fd-1ae7-01b5140987f0@joeconway.com>
 <20221006174343.GA444656@nathanxps13> <Yz+Jt9537vjfO733@paquier.xyz>
 <20221007032711.GA499771@nathanxps13> <Yz/Ii6dr1CSu4Bnv@paquier.xyz>
 <20221007194430.GA550749@nathanxps13>
Comments: In-reply-to Nathan Bossart <nathandbossart@gmail.com>
	message dated "Fri, 07 Oct 2022 12:44:30 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3347531.1665173939.1@sss.pgh.pa.us>
Date: Fri, 07 Oct 2022 16:18:59 -0400
Message-ID: <3347532.1665173939@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3347532.1665173939%40sss.pgh.pa.us>
Precedence: bulk

Nathan Bossart <nathandbossart@gmail.com> writes:
> On Fri, Oct 07, 2022 at 03:34:51PM +0900, Michael Paquier wrote:
>> Thanks.  I would perhaps use names less generic than role{1,2,3} for
>> the roles or "role1" for the database name, but the logic looks
>> sound.

> Here is a new version with more descriptive role names.

There's another problem there, which is that buildfarm animals
using -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS will complain
about role names that don't start with "regress_".

			regards, tom lane