Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uTip1-008tJq-U9 for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jun 2025 15:10:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uTioz-003zoB-MT for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jun 2025 15:10:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uTioz-003znv-CC for pgsql-hackers@lists.postgresql.org; Mon, 23 Jun 2025 15:10:58 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uTiox-003eul-17 for pgsql-hackers@lists.postgresql.org; Mon, 23 Jun 2025 15:10:57 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 55NFAjeP3353159; Mon, 23 Jun 2025 11:10:45 -0400 From: Tom Lane To: Nathan Bossart cc: John Naylor , Andy Fan , "Devulapalli, Raghuveer" , Jesper Pedersen , Tomas Vondra , "pgsql-hackers@lists.postgresql.org" , "Shankaran, Akash" Subject: Re: Improve CRC32C performance on SSE4.2 In-reply-to: References: <029f0848-8bc2-4d99-aebd-345949f97622@gmail.com> <87frg1dc3k.fsf@163.com> <87bjqncl24.fsf@163.com> <3350336.1750690281@sss.pgh.pa.us> Comments: In-reply-to Nathan Bossart message dated "Mon, 23 Jun 2025 10:05:49 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3353157.1750691445.1@sss.pgh.pa.us> Date: Mon, 23 Jun 2025 11:10:45 -0400 Message-ID: <3353158.1750691445@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Nathan Bossart writes: > On Mon, Jun 23, 2025 at 10:51:21AM -0400, Tom Lane wrote: >> This has broken the build completely on my RHEL8 x86_64 box, >> with gcc 8.5.0: > Unfortunately, this will probably require more than replacing > _mm512_castsi512_si128 with _mm512_zextsi512_si128 because the latter > doesn't exist. I was imagining just including _mm512_zextsi128_si512() in the code being tested during configure, so that we fall back to the non-AVX-512 code if the compiler is too old to have it. I don't really feel a need to work harder than that. regards, tom lane