From: Tom Lane <tgl@sss.pgh.pa.us>
To: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
cc: Andres Freund <andres@anarazel.de>, Euler Taveira <euler@eulerto.com>,
        "ranier.vf@gmail.com" <ranier.vf@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Small memory fixes for pg_createsubcriber
In-reply-to: <878qqb2ibm.fsf@wibble.ilmari.org>
References: <CAEudQAp=AW5dJXrGLbC_aZg_9nOo=42W7uLDRONFQE-gcgnkgQ@mail.gmail.com> <68d6d810-4ef1-4f62-b47f-89b21501249b@app.fastmail.com> <obqvpv4yx57lbnfiqvy4pmnfi2l5wn6xzoq2ftytxa426pa226@2sc46frt5xtb> <3337507.1739376124@sss.pgh.pa.us> <xseczrku4nm3p4rujapxiiuttpqrpagkbwrr2nlbnmwemh525y@3he54emhpqha> <878qqb2ibm.fsf@wibble.ilmari.org>
Comments: In-reply-to =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
	message dated "Wed, 12 Feb 2025 17:17:49 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3355446.1739380997.1@sss.pgh.pa.us>
Date: Wed, 12 Feb 2025 12:23:17 -0500
Message-ID: <3355447.1739380997@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3355447.1739380997%40sss.pgh.pa.us>
Precedence: bulk

=?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org> writes:
> Andres Freund <andres@anarazel.de> writes:
>> Particularly for something like libpq it's not quitetrivial to add
>> attributes like this, of course. We can't even depend on pg_config.h.
>> One way would be to define them in libpq-fe.h, guarded by an #ifdef, that's
>> "armed" by a commandline -D flag, if the compiler is supported?

> Does it need a -D flag, wouldn't __has_attribute(malloc) (with the
> fallback definition in c.h) be enough?

libpq-fe.h has to be compilable by application code that has never
heard of pg_config.h let alone c.h, so we'd have to tread carefully
about not breaking that property.  But it seems like this would be
worth looking into.

			regards, tom lane