Message-ID: <335f47af32e4042f9266c2b31d6ebc1aa0c22505.camel@cybertec.at>
Subject: Re: oid2name : add objects file path
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: David Bidoc <dcbidoc@gmail.com>, Michael Paquier <michael@paquier.xyz>
Cc: Guillaume Lelarge <guillaume.lelarge@dalibo.com>, 
	pgsql-hackers@lists.postgresql.org
Date: Wed, 14 Jan 2026 06:24:56 +0100
In-Reply-To: <CABour1tWqUQU0VtDRbhTy2hbMdOg0u15cb1vD=ZtRT-oAFMz8g@mail.gmail.com>
References: 
	<CABour1v2CU1wjjoM86wAFyezJQ3-+ncH43zY1f1uXeVojVN8Ow@mail.gmail.com>
	 <907f85f4-ca62-438e-9dcc-33d551d29969@app.fastmail.com>
	 <CABour1s9hhx508E51=pCJ6W7s0t=ywkBWoseRe9FW-=NNHwZRQ@mail.gmail.com>
	 <d709fac2-adac-4a1e-a33c-028549137a3c@dalibo.com>
	 <CABour1vvNTAA1S6zTVTiaz=PWcYFHar7Z6EEP0KRq7EaGAVAdg@mail.gmail.com>
	 <aTDZzIt5nlO0qO9W@paquier.xyz>
	 <CABour1tWqUQU0VtDRbhTy2hbMdOg0u15cb1vD=ZtRT-oAFMz8g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/335f47af32e4042f9266c2b31d6ebc1aa0c22505.camel%40cybertec.at>
Precedence: bulk

On Mon, 2025-12-15 at 15:30 +0100, David Bidoc wrote:
> I attached the rebased and updated patch.

That patch looks good to me, and I think that is a useful addition.

If you want to display the path of databases as well, as you tried to
do in the original patch, I think the way to go would be to write a
new SQL function pg_database_filepath() similar to pg_relation_filepath().
That shouldn't be too hard - would you want to try that?

Other than that, you could try to propose a commit message and
prepare your patch with

  git format-patch -v5 -1 -o /mypatches HEAD

after committing it to your branch.  That would make the committer's
work easier.

Yours,
Laurenz Albe