From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Simon Riggs <simon.riggs@enterprisedb.com>,
        Michael Paquier <michael@paquier.xyz>,
        Bernd Helmle <mailings@oopsware.de>,
        Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
        Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Subject: Re: Allowing REINDEX to have an optional name
In-reply-to: <20220715130334.p2qe6nefuod7ncex@alvherre.pgsql>
References: <20220715130334.p2qe6nefuod7ncex@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Fri, 15 Jul 2022 15:03:34 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3370902.1657893804.1@sss.pgh.pa.us>
Date: Fri, 15 Jul 2022 10:03:24 -0400
Message-ID: <3370903.1657893804@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3370903.1657893804%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Ah, one theory is that the libpq_pipeline program is getting linked to
> an installed version of libpq that doesn't contain the fixes.  Maybe you
> can do `ldd /path/to/libpq_pipeline` and see which copy of libpq.so it
> is picking up?

That's pronounced "otool -L" on macOS.  But in any case, it's going
to point at the installation directory.  One of the moving parts here
is that "make check" will try to override the rpath that otool tells
you about to make test programs use the libpq.dylib from the build tree.
I say "try" because if you've got SIP enabled (see what "csrutil status"
tells you), it will fail to do so and the installed libpq will be used.
Maybe that's old.

Standard recommendation on macOS with SIP on is to always do "make
install" before "make check".

			regards, tom lane