Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1eSM46-0002vh-7E
	for pgsql-hackers@arkaria.postgresql.org; Fri, 22 Dec 2017 12:04:38 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1eSM45-0006DN-I1
	for pgsql-hackers@arkaria.postgresql.org; Fri, 22 Dec 2017 12:04:37 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <sk@zsrv.org>)
	id 1eSM45-0006DD-7D
	for pgsql-hackers@lists.postgresql.org; Fri, 22 Dec 2017 12:04:37 +0000
Received: from forward5p.cmail.yandex.net ([2a02:6b8:0:1465::15])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <sk@zsrv.org>)
	id 1eSM41-0002BH-AX
	for pgsql-hackers@postgresql.org; Fri, 22 Dec 2017 12:04:35 +0000
Received: from mxback12g.mail.yandex.net (mxback12g.mail.yandex.net
 [IPv6:2a02:6b8:0:1472:2741:0:8b7:91])
	by forward5p.cmail.yandex.net (Yandex) with ESMTP id 440DD20FB1;
	Fri, 22 Dec 2017 15:04:28 +0300 (MSK)
Received: from web55j.yandex.ru (web55j.yandex.ru [2a02:6b8:0:1619::34f])
	by mxback12g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id
 toZXr07Sgx-4KX8OSCf;
	Fri, 22 Dec 2017 15:04:21 +0300
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zsrv.org; s=mail;
 t=1513944261;
	bh=2kyP6zEr0AMKV+EUzU4C+b9h6UzwmajLFH1kIIAmvE4=;
	h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date;
	b=B5pfXJjkGoI0y6ND8FBqE14xmynBTEo38cL7SfXsDgV4ScWgKMmgb1NC//DUUNPUn
	 1A9U+JwfF7l8CqWiojitzyKwlLMfFOW4ooIkw+1oYZEGd4o5+NiqBR6Lq5zaO6qw09
	 vulBcKLEQA4HiJKZOlVE3Uf4VJ+jgTyG2WxkPx2s=
Authentication-Results: mxback12g.mail.yandex.net;
 dkim=pass header.i=@zsrv.org
Received: by web55j.yandex.ru with HTTP;
	Fri, 22 Dec 2017 15:04:20 +0300
From: Sergei Kornilov <sk@zsrv.org>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,
	"michael.paquier@gmail.com" <michael.paquier@gmail.com>
Cc: "andres@anarazel.de" <andres@anarazel.de>,
	"peter.eisentraut@2ndquadrant.com" <peter.eisentraut@2ndquadrant.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
In-Reply-To: <20171222.150320.244267360.horiguchi.kyotaro@lab.ntt.co.jp>
References: <20171108.131431.170534842.horiguchi.kyotaro@lab.ntt.co.jp>
	<20171109.173128.220115527.horiguchi.kyotaro@lab.ntt.co.jp>
	<CAB7nPqS4bhSsDm_47GVjQno=iU6thx13MQVwwXXKBHQwfwwNCA@mail.gmail.com>
 <20171222.150320.244267360.horiguchi.kyotaro@lab.ntt.co.jp>
Subject: Re: [HACKERS] Restricting maximum keep segments by repslots
MIME-Version: 1.0
Message-Id: <337571513944260@web55j.yandex.ru>
X-Mailer: Yamail [ http://yandex.ru ] 5.0
Date: Fri, 22 Dec 2017 15:04:20 +0300
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Hello
I think limit wal in replication slots is useful in some cases. But first time i was confused with proposed terminology secured/insecured/broken/unknown state.

patch -p1 gives some "Stripping trailing CRs from patch" messages for me, but applied to current HEAD and builds. After little testing i understood the difference in secured/insecured/broken terminology. Secured means garantee to keep wal, insecure - wal may be deleted with next checkpoint, broken - wal already deleted.
I think, we may split "secure" to "streaming" and... hmm... "waiting"? "keeping"? - according active flag for clarify and readable "status" field.

regards, Sergei