From: Nikolay Shaplov <dhyan@nataraj.su>
To: Alexander Korotkov <aekorotkov@gmail.com>,
 pgsql-hackers@lists.postgresql.org
Cc: Andrei Lepikhov <a.lepikhov@postgrespro.ru>,
 jian he <jian.universality@gmail.com>, Robert Haas <robertmhaas@gmail.com>,
 pgsql-hackers@postgresql.org, Peter Geoghegan <pg@bowt.ie>,
 "Finnerty, Jim" <jfinnert@amazon.com>, Marcos Pegoraro <marcos@f10.com.br>,
 teodor@sigaev.ru, Tomas Vondra <tomas.vondra@enterprisedb.com>,
 Peter Eisentraut <peter@eisentraut.org>, Ranier Vilela <ranier.vf@gmail.com>,
 Alena Rybakina <a.rybakina@postgrespro.ru>
Subject: Re: POC, WIP: OR-clause support for indexes
Date: Mon, 24 Jun 2024 23:33:29 +0300
Message-ID: <3381819.e9J7NaK4W3@thinkpad-pgpro>
Organization: Postgres Professional
In-Reply-To: <196b44d5-f4e5-41a0-9a8f-9fbf26a13760@postgrespro.ru>
References:
 <567ED6CA.2040504@sigaev.ru>
 <CAPpHfdv087igFrMiU3yghtG9SmmYoWk0jP8WFJ9yR301CHit+w@mail.gmail.com>
 <196b44d5-f4e5-41a0-9a8f-9fbf26a13760@postgrespro.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart3736514.aeNJFYEL58";
 micalg="pgp-sha512"; protocol="application/pgp-signature"
Archived-At: <https://www.postgresql.org/message-id/3381819.e9J7NaK4W3%40thinkpad-pgpro>
Precedence: bulk

--nextPart3736514.aeNJFYEL58
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"; protected-headers="v1"
From: Nikolay Shaplov <dhyan@nataraj.su>
Subject: Re: POC, WIP: OR-clause support for indexes
Date: Mon, 24 Jun 2024 23:33:29 +0300
Message-ID: <3381819.e9J7NaK4W3@thinkpad-pgpro>
Organization: Postgres Professional
In-Reply-To: <196b44d5-f4e5-41a0-9a8f-9fbf26a13760@postgrespro.ru>
MIME-Version: 1.0

Hi!

Let me join the review process.

I am no expert in execution plans, so there would not be much help in doing=
=20
even better optimization. But I can read the code, as a person who is not f=
amiliar=20
with this area and help making it clear even to a person like me.

So, I am reading v25-0001-Transform-OR-clauses-to-ANY-expression.patch that=
=20
have been posted some time ago, and especially transform_or_to_any function.

> @@ -38,7 +45,6 @@
>  int			from_collapse_limit;
>  int			join_collapse_limit;
>
> -=20
>  /*
>   * deconstruct_jointree requires multiple passes over the join tree,  be=
cause we=20
>   * need to finish computing JoinDomains before we start  distributing qu=
als.

Do not think that removing empty line should be part of the patch

> +			/*
> +			 * If the const node's (right side of operator expression) type
> +			 * don't have =C3=A2=E2=82=AC=C5=93true=C3=A2=E2=82=AC=C2=9D array ty=
pe, then we cannnot do the
> +			 * transformation. We simply concatenate the expression node.
> +			 */
Guess using unicode double quotes is not the best idea here...=20
  =20
Now to the first part of  `transform_or_to_any`

--nextPart3736514.aeNJFYEL58
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEE+sk3ebqQKlezKOi8PMbfuIHAGpgFAmZ52BkACgkQPMbfuIHA
Gpj8xwgAk3O4NVDvaA1Xv0waWnaZc26R1CeCIIvGvqYXv+xKTsQzZfqnfeqbHwDM
peQkEpGgE1ZaizIoHwZqfnVy//S1bvOZfj9baziWi17KNw8F12brR4aGhtWG7CcI
MsDpl9BFAAvK6DkYEsG4xsP/Gjmj6AZz/MWChb8suHirbsVqpBFeD4y9eFM+RaEK
xbpnHZjgk+0JnNphjxxewZL7ZN35Ay+zx6fap2hgnA46kP0QV6JS3ZVhG+XclyQe
+lOu15EX960Fmd/8znx+zz+qI0VtbbKddlC5si+EY30G3G7LaN2lIYl93LV154o7
kOcfdqjrgSwhbPRSwHk3ylk2OOqHbw==
=RrQr
-----END PGP SIGNATURE-----

--nextPart3736514.aeNJFYEL58--