From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Geoghegan <pg@bowt.ie>
cc: Andres Freund <andres@anarazel.de>, Andrew Dunstan <andrew@dunslane.net>,
        Jelte Fennema <postgres@jeltef.nl>,
        Michael Paquier <michael@paquier.xyz>,
        "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
        Robert Haas <robertmhaas@gmail.com>,
        Justin Pryzby <pryzby@telsasoft.com>, Noah Misch <noah@leadboat.com>,
        Bruce Momjian <bruce@momjian.us>,
        Magnus Hagander <magnus@hagander.net>,
        Alvaro Herrera <alvherre@2ndquadrant.com>,
        Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Subject: Re: run pgindent on a regular basis / scripted manner
In-reply-to: <CAH2-Wz=+23=O6iioUR_k9-mgUoX2kJPOWW5JdOXmd5dCtvinVg@mail.gmail.com>
References: <1d66447e-a77b-ca0d-90a0-782800e85383@dunslane.net> <OSZPR01MB63100E1C06045FB66B16728BFDA09@OSZPR01MB6310.jpnprd01.prod.outlook.com> <e89d122e-6cf6-d0dc-8fe9-1dfa1de8dcab@dunslane.net> <CAGECzQSu6mLzPhd7csBfnXtW9kfoVRn5TWFH1fPGMc4mpkHyOw@mail.gmail.com> <ZEOfzsDrQ1SMOj4Q@paquier.xyz> <582c503b-cd98-1891-ff87-9c8e8ce73ee5@dunslane.net> <CAGECzQTvfpkyyRoGscSuS7ySCEXOO1DCi3eztHQbGEDrj_nt4g@mail.gmail.com> <30a72ba4-9ca4-15b5-db0f-0e68cba7ab26@dunslane.net> <1f594a4b-14c8-e159-b250-edf8a091320d@dunslane.net> <CAH2-WznOKBQ3HvdwvyXHz18T2u-brkE5umDUic4B-2vtavJKqA@mail.gmail.com> <20230811212511.aih23qfthi24zhq4@awork3.anarazel.de> <CAH2-Wz=+23=O6iioUR_k9-mgUoX2kJPOWW5JdOXmd5dCtvinVg@mail.gmail.com>
Comments: In-reply-to Peter Geoghegan <pg@bowt.ie>
	message dated "Fri, 11 Aug 2023 14:48:09 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <338201.1691793002.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Fri, 11 Aug 2023 18:30:02 -0400
Message-ID: <338202.1691793002@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/338202.1691793002%40sss.pgh.pa.us>
Precedence: bulk

Peter Geoghegan <pg@bowt.ie> writes:
> On Fri, Aug 11, 2023 at 2:25 PM Andres Freund <andres@anarazel.de> wrote:
>> We could a test that fails when there's some mis-indented code. That seems
>> like it might catch things earlier?

+1 for including this in CI tests

> It definitely would. That would go a long way towards addressing my
> concerns. But I suspect that that would run into problems that stem
> from the fact that the buildfarm is testing something that isn't all
> that simple. Don't typedefs need to be downloaded from some other
> blessed buildfarm animal?

No.  I presume koel is using src/tools/pgindent/typedefs.list,
which has always been the "canonical" list but up to now we've
been lazy about maintaining it.  Part of the new regime is that
typedefs.list should now be updated on-the-fly by patches that
add new typedefs.

We should still compare against the buildfarm's list periodically;
but I imagine that the primary result of that will be to remove
no-longer-used typedefs from typedefs.list.

			regards, tom lane