public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Robert Haas <[email protected]>
Cc: Maxim Orlov <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: Dilip Kumar <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: making relfilenodes 56 bits
Date: Thu, 29 Sep 2022 14:39:44 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmoaeS6YEhYNR8o_XyYnfdFTUnnVi15g_Vhje3TwTjPFyew@mail.gmail.com>
References: <CA+TgmoZfxMRfWW7X16TGWh1Q8taRtCb3hRTwWqY-4_XiQCYYKw@mail.gmail.com>
<CAFiTN-vTe79M8uDH1yprOU64MNFE+R3ODRuA+JWf27JbhY4hJw@mail.gmail.com>
<CA+TgmoZyKktnjNjpa_6wHfhNRaZfYS4Nfu--t8k5JgKkTR8paw@mail.gmail.com>
<CA+TgmoZTJsbJXoXWceQkaHdxjFz23BL=+xZiD64FgqVAQ77jPQ@mail.gmail.com>
<CAFiTN-s5ehHu2N9vuZcwg+NOENvf3v0FMXQQZq1faGjReP7mtw@mail.gmail.com>
<CA+TgmoZq5=LWDK7kHaUbmWXxcaTuw_QwafgG9dr-BaPym_U8WQ@mail.gmail.com>
<[email protected]>
<CA+TgmobwFU-D_cWAqUooUGaQrC91B5QOW79HF=n-1=ApmFh9=Q@mail.gmail.com>
<[email protected]>
<CA+TgmoacMgLv_0edhN=oWjnUvJyFjXww4Q4re4kfm+qkSBtjaQ@mail.gmail.com>
<[email protected]>
<CA+TgmoZhAAD+92KM6M73Rnpi_3YcCosMY=_ff-Eqhix3uzuSYA@mail.gmail.com>
<CAFiTN-s3E16MCR72sWVogrZ1B5_8p1eqK1fbWRYmLXV9LxYY6A@mail.gmail.com>
<CAFiTN-ttOXLX75k_WzRo9ar=VvxFhrHi+rJxns997F+yvkm==A@mail.gmail.com>
<[email protected]! mail.com>
<CAFiTN-uPcJ+-b228TVzVneW+2nZ09edgRU5D5v5Qmj-8g8AZag@mail.gmail.com>
<CA+TgmoYsNiF8JGZ+Kp7Zgcct67Qk++YAp+1ybOQ0qomUayn+7A@mail.gmail.com>
<CAA4eK1La-ZYvCjZAmShmGFvvhHNo2wbtSp80kXedS3d8A8R=aA@mail.gmail.com>
<CA+TgmoY7ZJw3V8McB=vN2m=sLmhaySY+7xNxuv1dgp+tYM6Hjw@mail.gmail.com>
<CAFiTN-uFRNufBmJTeM6cbm8EPe8BM8TteGBa5Spn9S+CDAj89w@mail.gmail.com>
<CAFiTN-tstcK1NUAsMaxQBc9GdHZh3=FEa2z-PubJmMU2xKn_pA@mail.gmail.com>
<CA+Tgmoap-iDjSFX6BjvyJtchmwEWxrQ9c=_bv_PtSAobkJ8PTw@mail.gmail.com>
<CAFiTN-tVnrcgdXCo_XgHja8=JqcqyssWV7uVdkEUTkHo7TiyBQ@mail.gmail.com>
<CAFiTN-u8mZYotV5K82y4zVqxW7jEQ3ovd-n+efXc4yK3B5H1ZA@mail.gmail.com>
<CA+TgmoZH65C4FuxTkWGg8iSx=wSL+13PeQY-Ggcd3e7ssQEiyw@mail.gmail.com>
<CAFiTN-snTvCca0Rd-1L3xtptD2YoO=QC_5RMUwCeqdB8foxsDg@mail.gmail.com>
<CAA4eK1+f=4O+yne0UHAm=UCjtP2V8cKjHTzFCd3ufgP9=cCDhg@mail.gmail.com>
<CAFiTN-uojTY8Nzb_+ZSmY4YvAbe+JD2JiEmV1p14Drdiay1x4A@mail.gmail.com>
<CAFiTN-s-BJ2URukJDYLbJh47td6xzcmE6S8R4r=FcnWcYSDnZQ@mail.gmail.com>
<CA+Tgmoas+r! [email protected]>
<CAFiTN-tVUocDK8Gi=rUs+4xUX35zApV725TtYdPX8qoYH7wsXA@mail.gmail.com>
<CAFiTN-un8Q5dOryPnqNvenN6hrDaoBP6C_KJH64v6NMAbHfeHA@mail.gmail.com>
<CA+TgmobFti5JuRZKq7hF8JJJgmyr1vpC-cOsu3dVc1dka9wApA@mail.gmail.com>
Robert Haas <[email protected]> writes:
> On Thu, Sep 29, 2022 at 10:50 AM Maxim Orlov <[email protected]> wrote:
>> In other words, we have 19 attributes. But tupdesc here is constructed for 18 elements:
>> tupdesc = CreateTemplateTupleDesc(18);
> I think that's a mistake. Thanks for the report.
The assertions in TupleDescInitEntry would have caught that,
if only utils/misc/pg_controldata.c had more than zero test coverage.
Seems like somebody ought to do something about that.
regards, tom lane
view thread (143+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: making relfilenodes 56 bits
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox