Message-ID: <339b3902-4e98-4e31-a744-94e43b7b9292@gmail.com>
Date: Sat, 1 Mar 2025 20:20:00 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Statistics Import and Export
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jeff Davis <pgsql@j-davis.com>, Andres Freund <andres@anarazel.de>,
 Corey Huinker <corey.huinker@gmail.com>,
 Michael Paquier <michael@paquier.xyz>, jian he
 <jian.universality@gmail.com>, Nathan Bossart <nathandbossart@gmail.com>,
 Bruce Momjian <bruce@momjian.us>,
 Matthias van de Meent <boekewurm+postgres@gmail.com>,
 Magnus Hagander <magnus@hagander.net>, Stephen Frost <sfrost@snowman.net>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
 Peter Smith <smithpb2250@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 alvherre@alvh.no-ip.org
References: <sdno5atrplq5b67vcx7x6fkzevwkzojd23izbguy2yma424wmp@siwbi3ijxdxs>
 <x5yo5ly5u3dhzfaq3hrzeqhju3io5zmwk4yqrkge3ywcflffck@ghbbgsfv56yb>
 <3670503.1740173078@sss.pgh.pa.us>
 <blezfpeafycxlizyynwvwzh2vywmklhvfqudhicjrccu4raqpx@4ttfufowc2vo>
 <3728741.1740178078@sss.pgh.pa.us>
 <CADkLM=f0a43aTd88xW4xCFayEF25g-7hTrHX_WhV40HyocsUGg@mail.gmail.com>
 <97b451228227c555be1a4f79c4a62ddec9a74f06.camel@j-davis.com>
 <CADkLM=ckXu5wzSQZ3Y_fvAaL8rZ+upZdSecBLf5FCTMj7M6T-A@mail.gmail.com>
 <b227c4fca29dfb893bb414ce6d84fc2377489ecc.camel@j-davis.com>
 <CADkLM=dRMC6t8gp9GVf6y6E_r5EChQjMAAh_vPyih_zMiq0zvA@mail.gmail.com>
 <y2d36zf6pl3n6ni6e4ctblu3a5iazi2dycknq53h2mjvp7lto4@hhww3h2qgdrw>
 <6af48508a32499a8be3398cafffd29fb6188c44b.camel@j-davis.com>
 <57988cee-5cc8-44f9-981e-8d62e556f5c8@gmail.com>
 <3043076.1740852261@sss.pgh.pa.us>
Content-Language: en-US
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <3043076.1740852261@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/339b3902-4e98-4e31-a744-94e43b7b9292%40gmail.com>
Precedence: bulk

Hello Tom,

01.03.2025 20:04, Tom Lane wrote:
> Alexander Lakhin <exclusion@gmail.com> writes:
>> It looks like 8f427187d broke pg_dump on Cygwin:
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&dt=2025-02-26%2010%3A03%3A07
> Yeah, Andrew and I have been puzzling over that off-list.  pg_dump
> is definitely exiting unceremoniously.
>
>> As far as I can see, it exits prematurely here:
>>                  float           reltuples = strtof(PQgetvalue(res, i, i_reltuples), NULL);
> I was suspecting those float conversions as a likely cause, but
> what do you think is wrong exactly?  I see nothing obviously
> buggy in pg_strtof().

 From my understanding, pg_strtof () can't stand against endptr == NULL.
I have changed that line to:
         char *tptr;
         float        reltuples = strtof(PQgetvalue(res, i, i_reltuples), &tptr);

and 002_compare_backups passed for me.

Best regards,
Alexander Lakhin
Neon (https://neon.tech)