Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poM0V-0003uB-5a for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Apr 2023 10:22:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1poM0U-00037n-0G for pgsql-hackers@arkaria.postgresql.org; Mon, 17 Apr 2023 10:22:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poM0T-00037E-Kr for pgsql-hackers@lists.postgresql.org; Mon, 17 Apr 2023 10:22:45 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1poM0N-003OvP-Gg for pgsql-hackers@lists.postgresql.org; Mon, 17 Apr 2023 10:22:44 +0000 Received: by mail-wm1-x330.google.com with SMTP id iw7-20020a05600c54c700b003f16fce55b5so1961030wmb.0 for ; Mon, 17 Apr 2023 03:22:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681726957; x=1684318957; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GXA+oOKcKSMPN5ylKKl/tqmbQDzbkExTQcORFvfsNcQ=; b=Hi6BpUBsWALw2rl4ePzCt1UOGS9S2WkdhiINdnOAq8XvWh9lyRJ9G6X3fChlVayGBQ 4ePy3BZJj6jp5NwyMxWzjBqxWvMSCocsb5d4IM9in3cISpvzI7zwLQoaBk3t/YWE2gtb k3mEwEYRUSp1U9atGz5uFCUYbRqrOb6/bUhuwI6/fOeuGCPR+oazohs1yEOkEDHV3L2k eap25pBGGoDxSOZL8kTUoWvwtSQ8qnR/QAkVY+XiCBnQNgwKy4ElXpFtFa9hdL6XQa7O zoQ/3X9vHgOED5cb/diyxNGjP32XmxZhmcsrZY58TaUX6gs4aIaOP/KJVRZhu1ObEQZ2 j05w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681726957; x=1684318957; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GXA+oOKcKSMPN5ylKKl/tqmbQDzbkExTQcORFvfsNcQ=; b=XjrQ8rj7bfN8e6ioAynMigF3z+AXPVl8i9vdLB10JxAEy3Mm/GdfjsfM6VJOKiCawr XypZ8qUN3HFEGrZYzr1iYTXwZ8Sge/IGC1DZa5TrbmjgQzptyjMtjE2xo/pk3P7jNCG8 XKpenNrACtrN1HBjfTn8eCfsQKXDmup/I1tmLBItqF97qs0WT8J5mv/x1HBsoKBpfwmX dbaLfOjRBBvnV2uu9IKmmU5+8KJdV9j+2PoQ+UQO6qiNFf61HrMmUWMyjR98KySAaPq/ I/Gm7Yx+DRhKOyT+gIrzLGTCQls0QU7qPRvUgyiIBu2XoHJICC2lDytztsoiUrTqklW/ 8QVg== X-Gm-Message-State: AAQBX9d3rgEGx/ta4NMovbBiAjohPkTJVI6E7Clk56n2N9hAbJugk+rL 8iBbHUNRaTUxLgq8X3womDk= X-Google-Smtp-Source: AKy350bqzfG9L7x6g6iI+G+NiMy2vtfXUx19Fb9NwmwY0Fsf7L6KVVpuxHTZYdL1Qxc3UEfaZ4ouOA== X-Received: by 2002:a7b:c004:0:b0:3ed:2a41:8525 with SMTP id c4-20020a7bc004000000b003ed2a418525mr10521961wmb.22.1681726957072; Mon, 17 Apr 2023 03:22:37 -0700 (PDT) Received: from [192.168.2.247] ([54.239.6.186]) by smtp.gmail.com with ESMTPSA id u7-20020a7bcb07000000b003ee70225ed2sm11610274wmj.15.2023.04.17.03.22.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Apr 2023 03:22:36 -0700 (PDT) Message-ID: <33c2b1b7-c5c7-f167-daba-8a53115cc025@gmail.com> Date: Mon, 17 Apr 2023 12:21:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: Add two missing tests in 035_standby_logical_decoding.pl Content-Language: en-US To: Alvaro Herrera Cc: PostgreSQL Hackers References: <20230417095528.mcx2pf2ge54d3t3i@alvherre.pgsql> From: "Drouvot, Bertrand" In-Reply-To: <20230417095528.mcx2pf2ge54d3t3i@alvherre.pgsql> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 4/17/23 11:55 AM, Alvaro Herrera wrote: > On 2023-Apr-12, Drouvot, Bertrand wrote: > >> I'm not sure if adding those 2 tests should be considered as an open >> item. I can add this open item if we think that makes sense. I'd be >> happy to do so but it looks like I don't have the privileges to edit >> https://wiki.postgresql.org/wiki/PostgreSQL_16_Open_Items > > I think adding extra tests for new code can definitely be considered an > open item, since those tests might help to discover issues in said new > code. > Thanks for the feedback! Added as an open item. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com