Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dNvrp-0000w9-1l for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Jun 2017 06:45:25 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dNvro-00012c-9s for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Jun 2017 06:45:24 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dNvrm-00012D-Cv for pgsql-hackers@postgresql.org; Thu, 22 Jun 2017 06:45:22 +0000 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]) by makus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dNvrb-0003O6-Gf for pgsql-hackers@postgresql.org; Thu, 22 Jun 2017 06:45:20 +0000 Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id v5M6j9W2009112 for ; Thu, 22 Jun 2017 15:45:09 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id D00835F65A; Thu, 22 Jun 2017 15:45:09 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id C433B5F623; Thu, 22 Jun 2017 15:45:09 +0900 (JST) Received: from [127.0.0.1] (unknown [129.60.241.61]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id BF3B2400BF0; Thu, 22 Jun 2017 15:45:09 +0900 (JST) From: Amit Langote Subject: Fix comment in xlog.c Message-ID: <33e9617d-27f1-eee8-3311-e27af98eaf2b@lab.ntt.co.jp> Date: Thu, 22 Jun 2017 15:44:58 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------0176A77E5CC856D4E836553E" Content-Language: en-US To: Pg Hackers X-TM-AS-MML: disable List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org This is a multi-part message in MIME format. --------------0176A77E5CC856D4E836553E Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Attached a patch for $SUBJECT. - * If RecPtr is not NULL, try to read a record at that position. Otherwise + * If RecPtr is valid, try to read a record at that position. Otherwise Commit 4d6d425ab8d addressed the comment above XLogReadRecord() in xlogreader.c, but missed the same above ReadRecord() in xlog.c. Backpatchable to 9.3, I'd think. Thanks, Amit --------------0176A77E5CC856D4E836553E Content-Type: text/plain; charset=UTF-8; name="xlog-comment-fix.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="xlog-comment-fix.patch" ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2cu YyBiL3NyYy9iYWNrZW5kL2FjY2Vzcy90cmFuc2FtL3hsb2cuYwppbmRleCA3 MGQyNTcwZGMyLi4xOTdlOWNjNzI2IDEwMDY0NAotLS0gYS9zcmMvYmFja2Vu ZC9hY2Nlc3MvdHJhbnNhbS94bG9nLmMKKysrIGIvc3JjL2JhY2tlbmQvYWNj ZXNzL3RyYW5zYW0veGxvZy5jCkBAIC00MTMyLDcgKzQxMzIsNyBAQCBDbGVh bnVwQmFja3VwSGlzdG9yeSh2b2lkKQogLyoKICAqIEF0dGVtcHQgdG8gcmVh ZCBhbiBYTE9HIHJlY29yZC4KICAqCi0gKiBJZiBSZWNQdHIgaXMgbm90IE5V TEwsIHRyeSB0byByZWFkIGEgcmVjb3JkIGF0IHRoYXQgcG9zaXRpb24uICBP dGhlcndpc2UKKyAqIElmIFJlY1B0ciBpcyB2YWxpZCwgdHJ5IHRvIHJlYWQg YSByZWNvcmQgYXQgdGhhdCBwb3NpdGlvbi4gIE90aGVyd2lzZQogICogdHJ5 IHRvIHJlYWQgYSByZWNvcmQganVzdCBhZnRlciB0aGUgbGFzdCBvbmUgcHJl dmlvdXNseSByZWFkLgogICoKICAqIElmIG5vIHZhbGlkIHJlY29yZCBpcyBh dmFpbGFibGUsIHJldHVybnMgTlVMTCwgb3IgZmFpbHMgaWYgZW1vZGUgaXMg UEFOSUMuCg== --------------0176A77E5CC856D4E836553E Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers --------------0176A77E5CC856D4E836553E--