Subject: Re: Doc necessity for superuser privileges to execute
 pg_import_system_collations()
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: torikoshia <torikoshia@oss.nttdata.com>,
 Pgsql Hackers <pgsql-hackers@postgresql.org>
References: <b7f484692a3e283710032e68b7f40617@oss.nttdata.com>
 <cd80c3df-e3aa-bf12-1544-631728d6c32b@oss.nttdata.com>
Message-ID: <33ff7667-bf4c-31ef-d33d-9df9d4c7c175@oss.nttdata.com>
Date: Wed, 21 Jul 2021 13:58:49 +0900
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <cd80c3df-e3aa-bf12-1544-631728d6c32b@oss.nttdata.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/33ff7667-bf4c-31ef-d33d-9df9d4c7c175%40oss.nttdata.com>
Precedence: bulk


On 2021/07/19 13:30, Fujii Masao wrote:
> 
> 
> On 2021/07/19 11:45, torikoshia wrote:
>> Hi.
>>
>> It seems that only superusers can execute pg_import_system_collations(), but this is not mentioned in the manual.
>>
>> Since other functions that require superuser privileges describe that in the manual, I think it would be better to do the same for consistency.
>>
>> Thoughts?
> 
> LGTM.
> 
> IMO it's better to back-patch this to v10
> where pg_import_system_collations() was added.

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION