Message-ID: <3407474c-9154-43b8-bff3-0cb3ebe53934@gmail.com>
Date: Sun, 19 Apr 2026 13:27:10 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: First draft of PG 19 release notes
To: Bruce Momjian <bruce@momjian.us>
Cc: PostgreSQL-development <pgsql-hackers@lists.postgresql.org>
References: <ad7ngXC125AvNqC2@momjian.us>
 <5d58c42f-11e2-432c-a926-49d16d890c99@gmail.com>
 <aeEKzO7sVZy_5Tzo@momjian.us>
 <79bc2b67-b0c1-4945-a5df-1b4f71d32a48@gmail.com>
 <aeJHRqGC0SN7mubg@momjian.us>
Content-Language: en-US
From: David Geier <geidav.pg@gmail.com>
In-Reply-To: <aeJHRqGC0SN7mubg@momjian.us>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/3407474c-9154-43b8-bff3-0cb3ebe53934%40gmail.com>
Precedence: bulk

>>> So, it seems there is no user-visible change, except it is faster.  Does
>>> it enable new workloads?  A 3x speedup probably does.  Should this be a
>>> pg_trgm item, with a description mentioning GIN in general, or should it
>>> be a GIN item, perhaps mentioning pg_trgm?  Do you have any suggested
>>> text and list of commits?
>>
>> Not all patches from the initial mail have been committed yet. Hence,
>> currently the speed up is less. However, once they got all committed
>> they would indeed open up new "use cases". For example, I know users
>> that don't add GIN indexes to very large tables because creating them
>> takes too long.
> 
> Yes, GIN index creation has always been considered slow, so it is good
> it is being worked on.  I wonder if we should just wait for it all to be
> committed before adding it to the release notes, unless you want to
> measure the improvement we have in PG 19.

I've measured with the same benchmark I used in the original thread [1].
With latest master the results are as follows:

Dataset  | REL_18_3   | master     | Speedup
---------|------------|------------|--------
movies   |  10,561 ms |   9,124 ms | 1.17x
lineitem | 263,523 ms | 234,605 ms | 1.12x

That's because three patches from the patchset haven't been committed
yet. Two of the three patches are the most impactful from the patchset.

[1]
https://www.postgresql.org/message-id/flat/5d366878-2007-4d31-861e-19294b7a583b%40gmail.com

--
David Geier