Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wVAtM-001ky0-0W
	for pgsql-hackers@arkaria.postgresql.org;
	Thu, 04 Jun 2026 16:26:00 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wVAtK-007p4K-2T
	for pgsql-hackers@arkaria.postgresql.org;
	Thu, 04 Jun 2026 16:25:58 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1wVAtK-007p45-1S
	for pgsql-hackers@lists.postgresql.org;
	Thu, 04 Jun 2026 16:25:58 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1wVAtI-00000001Glb-1bxe
	for pgsql-hackers@lists.postgresql.org;
	Thu, 04 Jun 2026 16:25:58 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.18.1/8.18.1) with ESMTP id 654GPq2m3425862;
	Thu, 4 Jun 2026 12:25:52 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ewan Young <kdbase.hack@gmail.com>
cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        Michael Paquier <michael@paquier.xyz>
Subject: Re: Use ereport() instead of elog() for invalid weights in
 setweight()
In-reply-to: 
 <CAON2xHOdAn73qVy6eBGnRHsfKG_70r=uTB_aTp4undkBpTJVQA@mail.gmail.com>
References: 
 <CAON2xHNaeLAUzRCXL5AmXLcXaSE_gWAVjWQRmLzc_oZ=1_Vf4Q@mail.gmail.com>
 <3096050.1780510673@sss.pgh.pa.us>
 <CAON2xHOdAn73qVy6eBGnRHsfKG_70r=uTB_aTp4undkBpTJVQA@mail.gmail.com>
Comments: In-reply-to Ewan Young <kdbase.hack@gmail.com>
	message dated "Thu, 04 Jun 2026 10:32:45 +0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3425860.1780590352.1@sss.pgh.pa.us>
Date: Thu, 04 Jun 2026 12:25:52 -0400
Message-ID: <3425861.1780590352@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/3425861.1780590352%40sss.pgh.pa.us>
Precedence: bulk

Ewan Young <kdbase.hack@gmail.com> writes:
> So v2 looks good to me.  Thanks for improving the patch!

Sounds good, pushed.

			regards, tom lane