Received: from localhost (unknown [200.46.208.211])
	by mail.postgresql.org (Postfix) with ESMTP id 2DDA6633D01
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Mon, 12 Oct 2009 16:02:12 -0300 (ADT)
Received: from mail.postgresql.org ([200.46.204.86])
	by localhost (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024)
	with ESMTP id 61924-01
	for <pgsql-hackers-postgresql.org@mail.postgresql.org>;
	Mon, 12 Oct 2009 19:01:58 +0000 (UTC)
X-Greylist: from auto-whitelisted by SQLgrey-1.7.6
Received: from sss.pgh.pa.us (sss.pgh.pa.us [66.207.139.130])
	by mail.postgresql.org (Postfix) with ESMTP id 3D50D63616E
	for <pgsql-hackers@postgresql.org>;
	Mon, 12 Oct 2009 15:42:25 -0300 (ADT)
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.2/8.14.2) with ESMTP id n9CIgJNS000344;
	Mon, 12 Oct 2009 14:42:19 -0400 (EDT)
To: Petr Jelinek <pjmodos@pjmodos.net>
cc: Jaime Casanova <jcasanov@systemguards.com.ec>,
	Robert Haas <robertmhaas@gmail.com>,
	Abhijit Menon-Sen <ams@toroid.org>, pgsql-hackers@postgresql.org
Subject: Re: GRANT ON ALL IN schema 
In-reply-to: <4AD14B31.5050309@pjmodos.net> 
References: <4A37BF63.50008@pjmodos.net>
	<a301bfd90907170254re7dd52es9fedb007376d8055@mail.gmail.com>
	<4A6059B4.5010004@pjmodos.net> <4A607997.3030305@pjmodos.net>
	<21542.1249492707@sss.pgh.pa.us> <4A7F56A0.5060705@pjmodos.net>
	<4A7F5853.5010506@pjmodos.net> <20090920145011.GA24273@toroid.org>
	<4AB75A51.5060807@pjmodos.net>
	<603c8f070909270954n585e8e8am9eb1c187dec9fe19@mail.gmail.com>
	<3073cc9b0910100045qdcb2b3duabc05eb727ea0091@mail.gmail.com>
	<4AD14B31.5050309@pjmodos.net>
Comments: In-reply-to Petr Jelinek <pjmodos@pjmodos.net>
	message dated "Sun, 11 Oct 2009 05:04:17 +0200"
Date: Mon, 12 Oct 2009 14:42:19 -0400
Message-ID: <343.1255372939@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
X-Virus-Scanned: Maia Mailguard 1.0.1
X-Spam-Status: No, hits=-2.583 tagged_above=-10 required=5 tests=AWL=0.016,
	BAYES_00=-2.599
X-Spam-Level: 
X-Archive-Number: 200910/680
X-Sequence-Number: 147492

Petr Jelinek <pjmodos@pjmodos.net> writes:
> [ latest GRANT ALL patch ]

I started looking at this, and the first thing I noticed was that it
adds TABLES, FUNCTIONS, and SEQUENCES as unreserved keywords.  Now
I'm not a fan of bloating the parser that way, but I have to admit
that "GRANT ON ALL TABLE IN SCHEMA" wouldn't read well.  What I am
wondering is whether we should not go back and adjust the syntax
for the default-ACLs patch to use the same keywords, ie not

ALTER DEFAULT PRIVILEGES ... GRANT ... ON TABLE TO ...

but

ALTER DEFAULT PRIVILEGES ... GRANT ... ON TABLES TO ...

Comments?

			regards, tom lane