Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLMe2-0000h2-MM for pgsql-hackers@arkaria.postgresql.org; Tue, 09 Aug 2022 10:39:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oLMe1-0002nS-17 for pgsql-hackers@arkaria.postgresql.org; Tue, 09 Aug 2022 10:39:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLMe0-0002nJ-EG for pgsql-hackers@lists.postgresql.org; Tue, 09 Aug 2022 10:39:28 +0000 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLMdx-0000VY-Qm for pgsql-hackers@postgresql.org; Tue, 09 Aug 2022 10:39:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1660041566; x=1691577566; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=WOJ+MEostAxB0wNlwNgwNb3wGT6yJ3psrO3wYR8FACY=; b=e36IIgUcEG0flKBatb63TLxrY9TbjuvQzD67BGGrqlv8Xjf3fkNMQY0P Vv6bXgROkQOhQsESq/9LkGbgD0ypJv4HKbXjJvIF/uZYOE5321w9WjyVZ t4XKMblBV45LllJhlBvCmKARofd2xtSrglhfTY+K0BNwbaOAXURLDlaf5 8=; Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-iad-1e-54c9d11f.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-6001.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2022 10:39:13 +0000 Received: from EX13D03EUC003.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-iad-1e-54c9d11f.us-east-1.amazon.com (Postfix) with ESMTPS id 0F85DC0430; Tue, 9 Aug 2022 10:39:10 +0000 (UTC) Received: from [192.168.29.205] (10.43.160.75) by EX13D03EUC003.ant.amazon.com (10.43.164.192) with Microsoft SMTP Server (TLS) id 15.0.1497.36; Tue, 9 Aug 2022 10:39:06 +0000 Message-ID: <34308245-ea21-82ee-b1fd-00b4766f3527@amazon.com> Date: Tue, 9 Aug 2022 12:39:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.1.1 Subject: Re: [PATCH] Expose port->authn_id to extensions and triggers Content-Language: en-US To: Michael Paquier CC: Joe Conway , Jacob Champion , Robert Haas , Tom Lane , "sfrost@snowman.net" , "rjuju123@gmail.com" , "pgsql-hackers@postgresql.org" , "andres@anarazel.de" References: <3b678314-054a-6119-b373-4574067f404e@timescale.com> From: "Drouvot, Bertrand" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.43.160.75] X-ClientProxiedBy: EX13D41UWC004.ant.amazon.com (10.43.162.31) To EX13D03EUC003.ant.amazon.com (10.43.164.192) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 8/9/22 11:17 AM, Michael Paquier wrote: > On Mon, Aug 08, 2022 at 12:43:14PM +0200, Drouvot, Bertrand wrote: >> but I'm not sure we should do it as a first step (given the fact that this >> is not Port->authn_id that is passed down to the parallel workers in the >> SYSTEM_USER patch). >> >> What do you think about working on both (aka a) v11-002 only >> ClientConnectionInfo and b) SYSTEM_USER) in parallel? > It seems to me that completing ClientConnectionInfo first has the > advantage of not having to tweak twice the interface we are going to > use when passing down the full structure to the workers, so I would > choose for doing it first (with one field for the authn, and a second > field for the auth method so as the the workers can build SYSTEM_USER > by themselves when required). Yeah fair point. Agree that it makes sense to work on those patches in this particular order then. Thanks, -- Bertrand Drouvot Amazon Web Services: https://aws.amazon.com