Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wE7If-003gp2-0c
	for pgsql-hackers@arkaria.postgresql.org;
	Sat, 18 Apr 2026 15:09:37 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.96)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1wE7Ie-00DAwz-1I
	for pgsql-hackers@arkaria.postgresql.org;
	Sat, 18 Apr 2026 15:09:36 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1wE7Ie-00DAwr-0P
	for pgsql-hackers@lists.postgresql.org;
	Sat, 18 Apr 2026 15:09:36 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.98.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1wE7Ic-00000001dZn-07Bw
	for pgsql-hackers@lists.postgresql.org;
	Sat, 18 Apr 2026 15:09:35 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 63IF9VdT3432491;
	Sat, 18 Apr 2026 11:09:31 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <dgrowleyml@gmail.com>
cc: Peter Eisentraut <peter@eisentraut.org>, Chao Li <li.evan.chao@gmail.com>,
        PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Add bms_offset_members() function for bitshifting Bitmapsets
In-reply-to: 
 <CAApHDvqJ_ZpO366cGMS2uheTzy0Kh8Qgk2hx+unfyKy1ifR6xw@mail.gmail.com>
References: 
 <CAApHDvq=eEdw2Qp+aSzSOtTSe+h0fnVQ55CcTNqBkLDYiRZmxw@mail.gmail.com>
 <278B9FE3-F349-4494-99C5-483105C1C999@gmail.com>
 <CAApHDvoALVPgVSCuGdAfNUbxx_NacnAd0nuj8Hi=_-61AEqzaQ@mail.gmail.com>
 <1900289.1776212948@sss.pgh.pa.us>
 <CAApHDvq4_WDfTaWX6nHU8TV+no+aD1zjLphza685Ek7=xgGzew@mail.gmail.com>
 <1913188.1776220247@sss.pgh.pa.us>
 <CAApHDvp=fhr8ksuGyXkwYPXQpYvJ38YMhHvx6JmdD39cAvNRhw@mail.gmail.com>
 <ee61a3c6-5d99-4b3e-87de-4a01eed449b2@eisentraut.org>
 <CAApHDvqJ_ZpO366cGMS2uheTzy0Kh8Qgk2hx+unfyKy1ifR6xw@mail.gmail.com>
Comments: In-reply-to David Rowley <dgrowleyml@gmail.com>
	message dated "Sat, 18 Apr 2026 19:53:40 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3432489.1776524971.1@sss.pgh.pa.us>
Date: Sat, 18 Apr 2026 11:09:31 -0400
Message-ID: <3432490.1776524971@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/3432490.1776524971%40sss.pgh.pa.us>
Precedence: bulk

David Rowley <dgrowleyml@gmail.com> writes:
> On Thu, 16 Apr 2026 at 07:17, Peter Eisentraut <peter@eisentraut.org> wrote:
>> Depending on what you end up doing, maybe a sprinkling of pg_nodiscard
>> could be appropriate.

> Yeah maybe. It wouldn't do any harm, at least.

> I didn't do that in the patch I just sent as it felt like something we
> should do or not do for all the bitmapset functions it's relevant for.

Agreed, seems like it should be a separate patch.

			regards, tom lane