From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <john.naylor@enterprisedb.com>
cc: Justin Pryzby <pryzby@telsasoft.com>, Erik Rijkers <er@xs4all.nl>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: fix typos
In-reply-to: 
 <CAFBsxsGeWFdz0kTWDN5HU4qhBJdJjU+aDookfofha80rqvieMA@mail.gmail.com>
References: <b79bfeff-d0e3-29a3-2576-0e325848dede@xs4all.nl>
 <20220801181136.GJ15006@telsasoft.com>
 <CAFBsxsGeWFdz0kTWDN5HU4qhBJdJjU+aDookfofha80rqvieMA@mail.gmail.com>
Comments: In-reply-to John Naylor <john.naylor@enterprisedb.com>
	message dated "Thu, 04 Aug 2022 17:21:38 +0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3437165.1659620465.1@sss.pgh.pa.us>
Date: Thu, 04 Aug 2022 09:41:05 -0400
Message-ID: <3437166.1659620465@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3437166.1659620465%40sss.pgh.pa.us>
Precedence: bulk

John Naylor <john.naylor@enterprisedb.com> writes:
> On Tue, Aug 2, 2022 at 1:11 AM Justin Pryzby <pryzby@telsasoft.com> wrote:
>   ereport(ERROR,
>   (errcode(ERRCODE_OBJECT_IN_USE),
> - errmsg("could not drop replication origin with OID %d, in use by PID %d",
> + errmsg("could not drop replication origin with OID %u, in use by PID %d",

> RepOriginId is a typedef for uint16, so this can't print the wrong answer,
> but it is inconsistent with other uses. So it seems we don't need to
> backpatch this one?

Um ... if it's int16, then it can't be an OID, so I'd say this message has
far worse problems than %d vs %u.  It should not use that terminology.

			regards, tom lane