Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mO1te-00045y-59 for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Sep 2021 18:02:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mO1tc-0001De-ER for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Sep 2021 18:02:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mO1tc-0001DW-6l for pgsql-hackers@lists.postgresql.org; Wed, 08 Sep 2021 18:02:04 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mO1tV-0001Oo-8R for pgsql-hackers@postgresql.org; Wed, 08 Sep 2021 18:02:02 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 188I1nFw3437464; Wed, 8 Sep 2021 14:01:49 -0400 From: Tom Lane To: Robert Haas cc: Christoph Berg , PostgreSQL Hackers Subject: Re: VARDATA_COMPRESSED_GET_COMPRESS_METHOD comment? In-reply-to: References: Comments: In-reply-to Robert Haas message dated "Wed, 08 Sep 2021 12:27:58 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3437462.1631124109.1@sss.pgh.pa.us> Date: Wed, 08 Sep 2021 14:01:49 -0400 Message-ID: <3437463.1631124109@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Robert Haas writes: > On Wed, Sep 8, 2021 at 11:33 AM Christoph Berg wrote: >> How about "compressed-in-line Datum" like on the comment 5 lines above? > That seems reasonable to me, but I think Tom Lane is responsible for > the current form of that comment, so it'd be nice to hear what he > thinks. Hmm ... looks like I copied-and-pasted that comment to the wrong place while rearranging stuff in aeb1631ed. The comment just below is off-point too. Will fix. regards, tom lane