From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
cc: Jeff Janes <jeff.janes@gmail.com>,
        Nikita Glukhov <n.gluhov@postgrespro.ru>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Andres Freund <andres@anarazel.de>,
        Oleg Bartunov <obartunov@postgrespro.ru>,
        Michael Paquier <michael@paquier.xyz>,
        Stas Kelvich <s.kelvich@postgrespro.ru>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>,
        Thomas Munro <thomas.munro@enterprisedb.com>,
        David Steele <david@pgmasters.net>,
        Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
        Robert Haas <robertmhaas@gmail.com>,
        Pavel Stehule <pavel.stehule@gmail.com>
Subject: Re: jsonpath
In-reply-to: <32541.1552759144@sss.pgh.pa.us>
References: 
 <CAPpHfdv2bro1224314aRijKJu1bfwEimKr6hExoOaF4sqSDTQA@mail.gmail.com>
 <CAPpHfdu4nKqccH0tE84fTJqc7qV-9_w_uic1_zGTYY4FEbQUOw@mail.gmail.com>
 <CAPpHfduk=0DOKa40A+0Gi-eo03on_7DZgLZV9vNGdgfUMF_v2w@mail.gmail.com>
 <CAPpHfdv+YtPtmircv0kDNH8t9CJ2u8NVGT0JMOxxG2Tdi9BAYg@mail.gmail.com>
 <eebc218c-7aaa-c425-6ba0-78b28c751830@2ndquadrant.com>
 <9f5f1247-29f4-17cd-edd9-38e9bcd95b14@postgrespro.ru>
 <CAPpHfdsxacOREFDAhhZFwL=-x8Z49LCrEK8T9Zn=SJY-EJ+S_Q@mail.gmail.com>
 <20190130022826.of7w6xv5lbvzqxfp@alap3.anarazel.de>
 <CAPpHfdvov6kWfT3hk8KMSah+kzNuN2AXaZfBqnSU0YkzDVkR2Q@mail.gmail.com>
 <957ee2ff-f9a6-0ba1-13e2-9c4d320f63ac@2ndquadrant.com>
 <CAPpHfdu+y1tkiidwu0i=XyGK5eOTOu1fPbuYs=XT32g7tzGd4Q@mail.gmail.com>
 <a3be6a7a-77d3-0e88-4f9d-4f725d11d7cd@postgrespro.ru>
 <CAPpHfdsW924B1eYLqgXE0SkH0ym2Zk32CqPwUu_CH65Gk_onrA@mail.gmail.com>
 <c25eb8a5-a129-bb7e-c930-761f0e2a6b71@2ndquadrant.com>
 <67128b8b-2d80-9e51-20a8-9ac8e0e2243e@2ndquadrant.com>
 <220821fb-52c0-c277-0959-322c8eef76b2@postgre!
 spro.ru> <CAPpHfdsyWVfW7N-T9-H1RjoRZCwQX4w5qRd6SGjbLP=qf_y9iw@mail.gmail.com>
 <CAPpHfdsLuSAGHbn06Qq83=XCDhW8RqFe8tFeq+rYhiNWD=bzFA@mail.gmail.com>
 <CAPpHfduXPikbeCnaVi1d2GQvKJLJcQ_GEe5KrzSPTV1KD0E8+Q@mail.gmail.com>
 <CAMkU=1w1qBvoW82ZTFpAKae027R-2OHw-m6ALe0VQRNAFueBVA@mail.gmail.com>
 <32541.1552759144@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Sat, 16 Mar 2019 13:59:04 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3446.1552759918.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 16 Mar 2019 14:11:58 -0400
Message-ID: <3448.1552759918@sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Good point.  I also see jsonpath_gram.h left behind after maintainer-cle=
an:

Oh, and of potentially more significance: after maintainer-clean and
re-configure, make fails with

In file included from jsonpath_gram.y:24:
../../../../src/include/utils/jsonpath_scanner.h:25:33: error: utils/jsonp=
ath_gram.h: No such file or directory

I first thought this was a problem with insufficient dependencies
allowing parallel make to do things in the wrong order, but the problem
repeats even without any parallelism.  It looks like the dependencies
have been constructed in such a way that if the symlink at
src/include/utils/jsonpath_gram.h exists but the underlying file
does not, nothing will make the underlying file.  This is pretty broken;
aside from this outright failure, it also suggests that nothing will
update that file if it exists but is out of date relative to its
sources.

Please make sure that the make rules associated with these files look
exactly like the previously-debugged rules for existing bison/flex
output files.  There are generally good reasons for every last bit
of weirdness in those.

			regards, tom lane