Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pEB8v-000867-Uc
	for pgsql-hackers@arkaria.postgresql.org; Sat, 07 Jan 2023 15:29:57 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pEB8u-0005ld-AS
	for pgsql-hackers@arkaria.postgresql.org; Sat, 07 Jan 2023 15:29:56 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pEB8u-0005lT-1X
	for pgsql-hackers@lists.postgresql.org; Sat, 07 Jan 2023 15:29:56 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pEB8r-0001tM-MN
	for pgsql-hackers@lists.postgresql.org; Sat, 07 Jan 2023 15:29:55 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 307FTn2c3448479;
	Sat, 7 Jan 2023 10:29:49 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: vignesh C <vignesh21@gmail.com>
cc: Eric Radman <ericshane@eradman.com>, Dag Lem <dag@nimrod.no>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Add function to_oct
In-reply-to: 
 <CALDaNm1MvZ39UziVoLMZhFjgS1F9+zJ_oKF9icO-aeK02jRb9g@mail.gmail.com>
References: <Y6IyTQQ/TsD5wnsH@vm3.eradman.com>
 <CAB8KJ=g4kbRPAPLq9jwKQbzqG8tX4gFAc2rFgz-SKjUzJ7PsFQ@mail.gmail.com>
 <167170369754.1121.7881078512513671914.pgcf@coridan.postgresql.org>
 <Y6SWxEM92Pbqs0l/@vm3.eradman.com>
 <CALDaNm1MvZ39UziVoLMZhFjgS1F9+zJ_oKF9icO-aeK02jRb9g@mail.gmail.com>
Comments: In-reply-to vignesh C <vignesh21@gmail.com>
	message dated "Sat, 07 Jan 2023 16:32:26 +0530"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3448477.1673105389.1@sss.pgh.pa.us>
Date: Sat, 07 Jan 2023 10:29:49 -0500
Message-ID: <3448478.1673105389@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/3448478.1673105389%40sss.pgh.pa.us>
Precedence: bulk

vignesh C <vignesh21@gmail.com> writes:
> Few suggestions
> 1) We could use to_oct instead of to_oct32 as we don't have multiple
> implementations for to_oct

That seems (a) shortsighted and (b) inconsistent with the naming
pattern used for to_hex, so I doubt it'd be an improvement.

			regards, tom lane