Date: Tue, 11 Jun 2019 15:19:43 +0300
From: Pavlo Golub <pavlo.golub@cybertec.at>
Message-ID: <345138875.20190611151943@cybertec.at>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
CC: Craig Ringer <craig@2ndquadrant.com>
Subject: ReplicationSlotCtl: undefined reference
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk

Greetings.

Trying to build pg extension I've got error:
```
pglogical_monitoring.o:pglogical_monitoring.c:(.rdata$.refptr.ReplicationSlotCtl[.refptr.ReplicationSlotCtl]+0x0): undefined reference to `ReplicationSlotCtl'
collect2: error: ld returned 1 exit status
```

But according to https://commitfest.postgresql.org/16/1390/ it should
be marked with PGDLLIMPORT.

However checking sources there is no this spec
(https://github.com/postgres/postgres/blob/fff2a7d7bd09db38e1bafc1303c29b10a9805dc0/src/include/replication/slot.h#L172):

```
extern ReplicationSlotCtlData *ReplicationSlotCtl;
```

Am I correct or missing smth?
Craig, it supposed to be your proposal about ReplicationSlotCtl and
patch. Am I right?

-- 
Kind regards,
 Pavlo                          mailto:pavlo.golub@cybertec.at