From: Tom Lane <tgl@sss.pgh.pa.us>
To: Laurenz Albe <laurenz.albe@cybertec.at>
cc: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org
Subject: Re: allow to \dtS+ pg_toast.*
In-reply-to: <75f515dda92a7576f18baf872ed7e45ca03db160.camel@cybertec.at>
References: <20201130165436.GX24052@telsasoft.com>
 <1839fe7148f3aa1a7b28da9064a5c2f8b08316c3.camel@cybertec.at>
 <20201218065808.GY30237@telsasoft.com>
 <c3fdffcfd26f4d433307fa80f6ef7f0b3b183f06.camel@cybertec.at>
 <20201218173312.GZ30237@telsasoft.com>
 <75f515dda92a7576f18baf872ed7e45ca03db160.camel@cybertec.at>
Comments: In-reply-to Laurenz Albe <laurenz.albe@cybertec.at>
	message dated "Mon, 21 Dec 2020 15:20:51 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3454490.1609890361.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 05 Jan 2021 18:46:01 -0500
Message-ID: <3454491.1609890361@sss.pgh.pa.us>
Precedence: bulk

Laurenz Albe <laurenz.albe@cybertec.at> writes:
> On Fri, 2020-12-18 at 11:33 -0600, Justin Pryzby wrote:
>>>> This makes toast tables a bit less special and easier to inspect.

Pushed, except for

>>> Another thing that is missing is tab completion for
>>> regression=3D# \dtS pg_toast.pg_
>>> This should work just like for \d and \dS.

>> I agree that it's nice to complete the schema name, but I'm still not c=
onvinced
>> this part should be included.

> Again a judgement call.  I am happy with the way the latest patch does i=
t.

I remain pretty much against including toast tables in tab completion,
so I left out that part.

>> I considered whether "toast table" should be capitalized (as it is for =
"\d")
>> but I think it should stay lowercase.

> Then you should also change the way \d does it (upper case).
> I think we should be consistent.

I think capitalized TOAST is correct, because it's an acronym.
I also agree that consistency with what \d shows is important,
and I have no desire to change \d's longstanding output.

			regards, tom lane