From: Tom Lane <tgl@sss.pgh.pa.us>
To: "'alvherre@alvh.no-ip.org'" <alvherre@alvh.no-ip.org>
cc: "iwata.aya@fujitsu.com" <iwata.aya@fujitsu.com>,
        "tsunakawa.takay@fujitsu.com" <tsunakawa.takay@fujitsu.com>,
        "'Kyotaro Horiguchi'" <horikyota.ntt@gmail.com>,
        "k.jamison@fujitsu.com" <k.jamison@fujitsu.com>,
        "pgsql-hackers@lists.postgresql.org"
 <pgsql-hackers@lists.postgresql.org>
Subject: Re: libpq debug log
In-reply-to: <3455705.1617299197@sss.pgh.pa.us>
References: <20210401161041.GA10892@alvherre.pgsql>
 <3455705.1617299197@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Thu, 01 Apr 2021 13:46:37 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3458957.1617302154.1@sss.pgh.pa.us>
Date: Thu, 01 Apr 2021 14:35:54 -0400
Message-ID: <3458958.1617302154@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3458958.1617302154%40sss.pgh.pa.us>
Precedence: bulk

So drongo is still failing, and after a bit of looking around at
other code I finally got hit with the clue hammer.  Per port.h:

 * On Windows, setvbuf() does not support _IOLBF mode, and interprets that
 * as _IOFBF.  To add insult to injury, setvbuf(file, NULL, _IOFBF, 0)
 * crashes outright if "parameter validation" is enabled.  Therefore, in
 * places where we'd like to select line-buffered mode, we fall back to
 * unbuffered mode instead on Windows.  Always use PG_IOLBF not _IOLBF
 * directly in order to implement this behavior.

You want to do the honors?  And do something about that shift bug
while at it.

			regards, tom lane