Subject: Re: query logging of prepared statements
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org
References: <20190208132953.GF29720@telsasoft.com>
 <20190215145704.GW30291@telsasoft.com> <20190227180653.GF28750@telsasoft.com>
 <70868e0d-2a29-36c8-e3e2-f54a56804bc4@postgrespro.ru>
 <20190304183150.GK29584@telsasoft.com>
From: Arthur Zakirov <a.zakirov@postgrespro.ru>
Message-ID: <345f3504-e3cd-3a01-c593-ebbbe555dd69@postgrespro.ru>
Date: Tue, 5 Mar 2019 13:30:18 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <20190304183150.GK29584@telsasoft.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 04.03.2019 21:31, Justin Pryzby wrote:
> It wasn't intentional.  Find attached v3 patch which handles that case,
> by removing the 2nd call to errdetail_execute() ; since it's otherwise unused,
> so remove that function entirely.

Thank you.

> Thanks for reviewing.  I'm also interested in discussion about whether this
> change is undesirable for someone else for some reason ?  For me, the existing
> output seems duplicative and "denormalized".  :)

I perfectly understand your use case. I agree, it is duplicated. But I 
think some people may want to see it at every EXECUTE, if they don't 
want to grep for the prepared statement body which was logged earlier.

I think it would be good to give possibility to configure this behavior. 
At first version of your patch you relied on log_error_verbosity GUC. 
I'm not sure that this variables is suitable for configuring visibility 
of prepared statement body in logs, because it sets more general 
behavior. Maybe it would be better to introduce some new GUC variable if 
the community don't mind.

-- 
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company