From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Andres Freund <andres@anarazel.de>, Dag Lem <dag@nimrod.no>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: daitch_mokotoff module
In-reply-to: <CA+hUKG+Gs3WXzbT4OK9gEXpC1e221RafrPS4LVvcDDgDi20xAg@mail.gmail.com>
References: <yger1atbgfy.fsf@sid.nimrod.no> <ygek0g87hgx.fsf@sid.nimrod.no> <0cac2d60-5b85-59c6-1ac1-77092b8688b7@enterprisedb.com> <ygelf0mizon.fsf@sid.nimrod.no> <yge7dbxhc01.fsf@sid.nimrod.no> <20220102213150.y2tpuwqhruu5t2y5@alap3.anarazel.de> <CA+hUKG+Gs3WXzbT4OK9gEXpC1e221RafrPS4LVvcDDgDi20xAg@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Mon, 03 Jan 2022 14:47:05 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <3461032.1641177713.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Sun, 02 Jan 2022 21:41:53 -0500
Message-ID: <3461033.1641177713@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/3461033.1641177713%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> Erm, it looks like something weird is happening somewhere in cfbot's
> pipeline, because Dag's patch says:

> +SELECT daitch_mokotoff('Straßburg');
> + daitch_mokotoff
> +-----------------
> + 294795
> +(1 row)

... so, that test case is guaranteed to fail in non-UTF8 encodings,
I suppose?  I wonder what the LANG environment is in that cfbot
instance.

(We do have methods for dealing with non-ASCII test cases, but
I can't see that this patch is using any of them.)

			regards, tom lane