Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzLtd-0006PI-0y for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Jan 2021 15:47:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kzLta-00043R-2P for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Jan 2021 15:47:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kzLtZ-00043J-QD for pgsql-hackers@lists.postgresql.org; Tue, 12 Jan 2021 15:47:45 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kzLtX-0004rZ-2K for pgsql-hackers@lists.postgresql.org; Tue, 12 Jan 2021 15:47:45 +0000 Received: from [192.168.27.200] (unknown [93.174.131.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id BAB6621C2F7E; Tue, 12 Jan 2021 18:47:41 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1610466461; bh=aFn0D6R36Iii3zhzmTxKivHoAXoUpgTOrsskmr9rSsg=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=S35+kQX1ngWowDkeaDDVRxcz6OAfpKKAVYHHsq6nCR/D2cNv3zeFkcLBbZSXteavI zy85bVqL6ykw7NwrWGa++3eYegNUgfBkzYzmiO38lR8Jy7PPIJ+JONH26om96wwHom R+6JRl73zZ2lDFZ9ux9eg01tYnOIv7AMNPlyiAw8= Subject: Re: libpq compression To: Justin Pryzby , Konstantin Knizhnik Cc: Tomas Vondra , Denis Smirnov , Daniil Zakhlystov , Andrey Borodin , Dilip Kumar , PostgreSQL Hackers References: <93027ee4-fefa-a8ca-2cc7-245c912bf824@postgrespro.ru> <20210109203119.GL1849@telsasoft.com> <20210112153822.GA1849@telsasoft.com> From: Konstantin Knizhnik Message-ID: <34620db4-b953-50b2-4648-8d4b0a7aad4f@postgrespro.ru> Date: Tue, 12 Jan 2021 18:47:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20210112153822.GA1849@telsasoft.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 12.01.2021 18:38, Justin Pryzby wrote: > On Tue, Jan 12, 2021 at 08:44:43AM +0300, Konstantin Knizhnik wrote: >> On 11.01.2021 20:38, Tomas Vondra wrote: >>> 1) Fixes the MSVC makefile. The list of files is sorted alphabetically, >>> so I've added the file at the end. >> Thank you > This is still failing the windows build. > > I think you need something like this, which I have in my zstd/pg_dump patch. > > --- a/src/tools/msvc/Solution.pm > +++ b/src/tools/msvc/Solution.pm > @@ -307,6 +307,7 @@ sub GenerateFiles > HAVE_LIBXML2 => undef, > HAVE_LIBXSLT => undef, > HAVE_LIBZ => $self->{options}->{zlib} ? 1 : undef, > + HAVE_LIBZSTD => $self->{options}->{zstd} ? 1 : undef, > Thank you. > I think we should come up with an minimal, prelimininary 0001 patch which is > common between the 3 compression patches (or at least the two using zstd). The > ./configure changes and a compressionlibs struct would also be included. I'm > planning to do something like this with the next revision of my patchset. > It will be great to have such common preliminary patch including zstd support. -- Konstantin Knizhnik Postgres Professional: http://www.postgrespro.com The Russian Postgres Company