Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w3K7h-00175K-1X for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Mar 2026 20:37:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1w3K7f-002kB8-34 for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Mar 2026 20:37:40 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w3K7f-002kB0-1F for pgsql-hackers@lists.postgresql.org; Thu, 19 Mar 2026 20:37:39 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1w3K7e-000000003jJ-09IX for pgsql-hackers@lists.postgresql.org; Thu, 19 Mar 2026 20:37:38 +0000 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-43b3d9d0695so1078064f8f.0 for ; Thu, 19 Mar 2026 13:37:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cybertec.at; s=google; t=1773952656; x=1774557456; darn=lists.postgresql.org; h=message-id:date:content-id:mime-version:comments:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=uRvY0dxKwRIRFHrSF8XqYfqBX/b+KqSkCtXhSSII0tk=; b=iMgl7StKJbrMDMMZcEZJnoH7dzpjQaPc2tNd+g2KhFGgWNqTPMY/D3hpI0Y+7SwLqq uPWNIWZSodnWipYQ6PmZgT1xMo8CfZSUsQ/nNV8VJoR+eAZ9qpQ59rUlv4maZCnA4WTu lyxo/EHQNGxT6K30qCVGeaQ8Am/qE4LaM23cm0soWoBxJju+ExIZpuqztp6LIrTvI85r xffk0GxrRnzSkqmqoq5K6G33MYNA1R0gz4/Vd/m+SSQuP7AtYqHJghZwqS95LFGpSt3J eC899RHmOynSBnLu7GXRSptVy3OEntonl3oaHyFRfp9nePRwyqqJMA6y4Uxd1sMpmrGN 7cyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773952656; x=1774557456; h=message-id:date:content-id:mime-version:comments:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=uRvY0dxKwRIRFHrSF8XqYfqBX/b+KqSkCtXhSSII0tk=; b=j6+WVJIAZVYAT2xYgMDEUpgj9mHMqk4pSynrcjkRHC/+39YCBqxhJwxElRbeqH7Q1f B3afIkbL02Do6sHp6Ac86Oz9Mpn2TFqjTWMfSJg/vgw0j80owx3cjKLzCn8MJHHs1bLs 8kSFmz2BpYPJtEt4upQ072IQnBbdKPiF5e9UsJcGGPNHTcKVX8fSk8QNHy7aPi3wKsBI 70ky/ZY+ko+4dLLwwiBJtokQGr+4wEeWaFGHId/w29nDUJ26wl1pF816456YBCr3rjRp dIgI8ehJZNGun8QoCnpeuOsh9wKvLqIwbVVCsorxoIrTyvSCvT6US4+7GV/m8NO51iML igNw== X-Forwarded-Encrypted: i=1; AJvYcCWNC95dP1qeW+mGbqSb90naptAV8pTLFFedo4lOjquZB06mgW0a2HHKBGx25BKet4z/dIutgI4PfGX2IKqH@lists.postgresql.org X-Gm-Message-State: AOJu0YzJ4BJwIPqTYU46+hZ9bVh5O/B1Dwz7IFSJdTzpJQ6RsH+Svk6h TF0McYi4yQ+QaviLJ9mWkRb4XfDvjSn+CN/ZGQ0nUyMuPZwxylihu3i1pXEaVkWlWks= X-Gm-Gg: ATEYQzy/0KBC4yP5TM77QwZuSisxQSPT+rlHS8f1aCedKNwsGBEzSPRqK7y3O9kSB2v iDUpjRRT8bxNrCKZn4w88bEXUElKzle97utNQCdJ3ysnrlORdsSAxV/rZejq63HsU/JbhR3PonN ytOl33hMv8TudpABSjf9lzXNDRWU9k1laW3YTKs+BAhUOZTHOrF7/RkWWbdzXGah0NeyDhFaNu3 oS5DGudTdHNsjrOTI0fGxFsikVtmJhHIsXPF4fGaiRMvzLOg91nk9zCcguX6HcoU+7fo0N5Ojy0 7JiGXb6NyCR1BSUzh58GFuLToWCRy8UY69DGsnJ8hBbJd44YsmGW2IUFt8ml+YC5PnMxqas4Sw7 BAi1uhQQatmjtqmM+LA9GQRRTkQQyrKauk6bnYoPyOSIuqivNjutKPKylLCyKyL5FxKJFowRDMP HSIldAeXbb2G1j/UYmJDvWvn/CgvEN8B/wMY5KymzicGZDptc= X-Received: by 2002:a05:6000:2f84:b0:43b:4703:9dcf with SMTP id ffacd0b85a97d-43b642724b2mr1269295f8f.15.1773952656494; Thu, 19 Mar 2026 13:37:36 -0700 (PDT) Received: from localhost (109-81-168-142.rct.o2.cz. [109.81.168.142]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b644bd923sm1065078f8f.12.2026.03.19.13.37.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2026 13:37:36 -0700 (PDT) From: Antonin Houska To: Alvaro Herrera cc: Srinath Reddy Sadipiralla , Matthias van de Meent , Mihail Nikalayeu , Pg Hackers , Robert Treat Subject: Re: Adding REPACK [concurrently] In-reply-to: <202603191855.fzsgsnyzfvpt@alvherre.pgsql> References: <202603191855.fzsgsnyzfvpt@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Thu, 19 Mar 2026 20:52:37 +0100." X-Mailer: MH-E 8.6+git; nmh 1.8; GNU Emacs 28.3 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <34691.1773952655.1@localhost> Date: Thu, 19 Mar 2026 21:37:35 +0100 Message-ID: <34692.1773952655@localhost> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Alvaro Herrera wrote: > So here's v43. Here, I've changed the CONCURRENTLY implementation to go > through table AM. This necessitated changing it to use tuples in slots > instead of HeapTuple. This is good because we can avoid repeated tuple > form/deform, which could get pretty expensive. Antonin's 0004 patch > here looks suspicious here though, because it deforms the tuple and > forms it again, which sounds unnecessary now. I suppose you mean v42-0004-Serialize-decoded-tuples-without-flattening.patch. This deforms the tuple to get the external attributes and to write them to file. The tuple the logical worker received from reorderbuffer.c cannot be passed to the backend executing REPACK because it may contain "external indirect" attributes, i.e. pointers to the worker's memory. -- Antonin Houska Web: https://www.cybertec-postgresql.com