From: Antonin Houska <ah@cybertec.at>
To: pgsql-hackers@postgresql.org
Subject: RLS makes COPY TO process child tables
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Date: Wed, 01 Feb 2023 12:45:57 +0100
Message-ID: <3472.1675251957@antos>
Archived-At: <https://www.postgresql.org/message-id/3472.1675251957%40antos>
Precedence: bulk

--=-=-=
Content-Type: text/plain

While working on [1] I noticed that if RLS gets enabled, the COPY TO command
includes the contents of child table into the result, although the
documentation says it should not:

	"COPY TO can be used only with plain tables, not views, and does not
	copy rows from child tables or child partitions. For example, COPY
	table TO copies the same rows as SELECT * FROM ONLY table. The syntax
	COPY (SELECT * FROM table) TO ... can be used to dump all of the rows
	in an inheritance hierarchy, partitioned table, or view."

A test case is attached (rls.sql) as well as fix proposal
(copy_rls_no_inh.diff).

[1] https://commitfest.postgresql.org/41/3641/

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com


--=-=-=
Content-Type: text/plain
Content-Disposition: inline; filename=rls.sql

create table a(i int);
insert into a values (1);

create table a1() inherits(a);
insert into a1 values (1);

-- Only the parent table is copied, as the documentation claims.
copy a to stdout;

alter table a enable row level security;
create role u;
create policy pol_perm on a as permissive for select to u using (true);
grant select on table a to u;
set role u;

-- Both "a" and "a1" appears in the output.
copy a to stdout;

--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline; filename=copy_rls_no_inh.diff

diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c
index e34f583ea7..3b8c25dadd 100644
--- a/src/backend/commands/copy.c
+++ b/src/backend/commands/copy.c
@@ -249,6 +249,7 @@ DoCopy(ParseState *pstate, const CopyStmt *stmt,
 			from = makeRangeVar(get_namespace_name(RelationGetNamespace(rel)),
 								pstrdup(RelationGetRelationName(rel)),
 								-1);
+			from->inh = false;
 
 			/* Build query */
 			select = makeNode(SelectStmt);

--=-=-=--