From: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavel Stehule <pavel.stehule@gmail.com>
cc: jian he <jian.universality@gmail.com>, Christoph Berg <myon@debian.org>,
        Michael Banck <mbanck@gmx.net>,
 Tommy Pavlicek <tommypav122@gmail.com>,
        =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Better error reporting from extension scripts (Was: Extend ALTER
 OPERATOR)
In-reply-to: 
 <CAFj8pRALVX8XDY9uZz_JCqd8k5VQjMLk3eGc=STonhMvJoLCSw@mail.gmail.com>
References: 
 <CAEhP-W_1bMTLan2LtzS+xr=b-Wep56gw+OoirABQ8b2aOw+5yg@mail.gmail.com>
 <ZTfL1G1fBPQHVPWV@msg.df7cb.de> <560086.1698160614@sss.pgh.pa.us>
 <ZTfjXzOKFI9AawJF@msg.df7cb.de> <570833.1698162135@sss.pgh.pa.us>
 <66f33840.050a0220.1f9e60.7fb9@mx.google.com> <ZvV1ClhnbJLCz7Sm@msg.df7cb.de>
 <325394.1727365907@sss.pgh.pa.us> <ZvaiS57G10dITjQm@msg.df7cb.de>
 <571930.1727454668@sss.pgh.pa.us> <Zvbr5zv78AfhB83S@msg.df7cb.de>
 <621972.1727459684@sss.pgh.pa.us> <1092841.1727552736@sss.pgh.pa.us>
 <2245576.1728418678@sss.pgh.pa.us>
 <CACJufxEhaR4Tj0gLvVnRuY_Vs=BqY6LbyMZo_0acnKOdnp5ROQ@mail.gmail.com>
 <CAFj8pRALVX8XDY9uZz_JCqd8k5VQjMLk3eGc=STonhMvJoLCSw@mail.gmail.com>
Comments: In-reply-to Pavel Stehule <pavel.stehule@gmail.com>
	message dated "Sun, 13 Oct 2024 18:48:03 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <3482021.1728839631.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Sun, 13 Oct 2024 13:13:51 -0400
Message-ID: <3482022.1728839631@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3482022.1728839631%40sss.pgh.pa.us>
Precedence: bulk

Pavel Stehule <pavel.stehule@gmail.com> writes:
> so 12. 10. 2024 v 9:33 odesílatel jian he <jian.universality@gmail.com>
> napsal:
>> + /*
>> + * If we have a location (which, as said above, we really always should)
>> + * then report a line number to aid in localizing problems in big scripts.
>> + */
>> + if (location >= 0)
>> so this part will always be true?

> yes, after  CleanQuerytext the location should not be -1 ever

Right, but we might not have entered either of those previous
if-blocks.  The question here is whether the raw parser (gram.y)
ever throws an error that doesn't include a cursor position.  IMO it
shouldn't, but a quick look through gram.y finds a few ereports that
lack parser_errposition.  We could go fix those, and probably should,
but imagining that none will ever be introduced again seems like
folly.

			regards, tom lane