Message-ID: <348bd8970506784d20c864a9a731420ca15a2f63.camel@j-davis.com>
Subject: Re: Statistics Import and Export
From: Jeff Davis <pgsql@j-davis.com>
To: Corey Huinker <corey.huinker@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, jian he
 <jian.universality@gmail.com>,  Nathan Bossart <nathandbossart@gmail.com>,
 Bruce Momjian <bruce@momjian.us>, Matthias van de Meent
 <boekewurm+postgres@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Magnus
 Hagander <magnus@hagander.net>, Stephen Frost <sfrost@snowman.net>,
 Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Peter Smith
 <smithpb2250@gmail.com>,  PostgreSQL Hackers
 <pgsql-hackers@lists.postgresql.org>, alvherre@alvh.no-ip.org
Date: Thu, 20 Feb 2025 01:39:34 -0800
In-Reply-To: <26e55538fa8c47d660642f367cd8a19333420789.camel@j-davis.com>
References: 
	<CADkLM=fe4f=YVGHbOGiXV+W2SoJZtcNw1Ta8gYh5UUhxndaVgw@mail.gmail.com>
	 <CACJufxGuRPfd70NwogkRE26cZcKGrR9gjG4OiH18tu=BnyezHA@mail.gmail.com>
	 <CADkLM=fMuVwcxr2aocz4H=LVf2PZsvTNenqEod2PoY1OyCU+kw@mail.gmail.com>
	 <bd72b9c9ce285350c5ce247f43b21bea39f24326.camel@j-davis.com>
	 <CADkLM=cQi+sYpLY6BqybZ8ZWffSU4+1-aEQsShSGbrh3M=Dtcg@mail.gmail.com>
	 <b40b81d38c3a87fdef61e4f7abfbc7f27c7fbcd9.camel@j-davis.com>
	 <CACJufxG6K4EAUROhdr0wkzMh5QyFLmdLZeAoh7Vh0-VbuAtHcw@mail.gmail.com>
	 <CADkLM=fihosVw7fJak6Jq1AdCX8fuZ+7s1_-+AUZR=sdD13zAQ@mail.gmail.com>
	 <CADkLM=cnYxaNFbAQRMLeOOga0j5pY_V6Tfcn+vjm_rXL=WOF7Q@mail.gmail.com>
	 <0b4c098ae3968aa23d6accb691f47bdba143aedd.camel@j-davis.com>
	 <Z6WjFqX4f3LVMydD@paquier.xyz>
	 <CADkLM=fzX7QX6r78fShWDjNN3Vcr4PVAnvXxQ4DiGy6V=0bCUA@mail.gmail.com>
	 <e048dd2e1e6afe55a2521f853e8346f39473ec7d.camel@j-davis.com>
	 <CADkLM=cALMHZkXU+xZw9-WeR4XSXzDYj_-xERHg8haYq1zbjhg@mail.gmail.com>
	 <26e55538fa8c47d660642f367cd8a19333420789.camel@j-davis.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
MIME-Version: 1.0
Archived-At: <https://www.postgresql.org/message-id/348bd8970506784d20c864a9a731420ca15a2f63.camel%40j-davis.com>
Precedence: bulk

On Wed, 2025-02-12 at 19:00 -0800, Jeff Davis wrote:
> I'm still reviewing v48, but I intend to commit something soon.

Committed with some revisions on top of v48:

* removed the short option -X, leaving the long option "--statistics-
only" with the same meaning.

* removed the redundant --with-statistics option for pg_upgrade,
because that's the default anyway.

* removed an unnecessary enum TocEntryType and cleaned up the API to
just pass the desired prefix directly to _printTocEntry().

* stabilized the 002_pg_upgrade test by turning off autovacuum before
the first pg_dumpall (we still want it to run before that to collect
stats).

* stabilized the 027_stream_regress recovery test by specifying --no-
statistics when comparing the data on primary and standby

* fixed the cross-version upgrade tests by using the
adjust_old_dumpfile to replace the version specifier with 000000 in the
argument list to pg_restore_* functions.

Regards,
	Jeff Davis