Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9uOd-0002CP-Ev for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Jul 2022 20:16:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o9uOc-00069v-AJ for pgsql-hackers@arkaria.postgresql.org; Fri, 08 Jul 2022 20:16:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9uOc-0005vo-1A for pgsql-hackers@lists.postgresql.org; Fri, 08 Jul 2022 20:16:14 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9uOX-0002XL-39 for pgsql-hackers@postgresql.org; Fri, 08 Jul 2022 20:16:10 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 268KG7sR3491000; Fri, 8 Jul 2022 16:16:07 -0400 From: Tom Lane To: Peter Eisentraut cc: David Rowley , pgsql-hackers Subject: Re: automatically generating node support functions In-reply-to: <3488143.1657310625@sss.pgh.pa.us> References: <50fedc80-4104-bdc8-d777-04f030fc550f@dunslane.net> <7848b872-7a10-67b2-b55f-7c9c475ae863@enterprisedb.com> <40a2e977-98ba-0c01-af6c-9dfb39e864ba@enterprisedb.com> <812ea8eb-6827-ba32-6ec0-6714f7ffa5dd@enterprisedb.com> <2905876.1644858587@sss.pgh.pa.us> <968928d9-a526-a1b5-dc36-0355632a843e@enterprisedb.com> <1294462.1656875649@sss.pgh.pa.us> <57df9f30-d2cf-9126-28d4-ae40a2e733a9@enterprisedb.com> <1593978.1656953960@sss.pgh.pa.us> <2592455.1657140387@sss.pgh.pa.us> <3302658.1657288366@sss.pgh.pa.us> <611d2e! ! 93-6330-47fa-0970-72316aed50f2@enterprisedb.com> <3488143.1657310625@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Fri, 08 Jul 2022 16:03:45 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3490998.1657311367.1@sss.pgh.pa.us> Date: Fri, 08 Jul 2022 16:16:07 -0400 Message-ID: <3490999.1657311367@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I wrote: > 0003 moves the node-level attributes as discussed. Meh. Just realized that I forgot to adjust the commentary in nodes.h about where to put node attributes. Maybe like - * Attributes can be attached to a node as a whole (the attribute - * specification must be at the end of the struct or typedef, just before the - * semicolon) or to a specific field (must be at the end of the line). The + * Attributes can be attached to a node as a whole (place the attribute + * specification on the first line after the struct's opening brace) + * or to a specific field (place it at the end of that field's line). The * argument is a comma-separated list of attributes. Unrecognized attributes * cause an error. regards, tom lane