Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pajox-0006aL-Gr for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Mar 2023 20:58:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pajov-00020P-7E for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Mar 2023 20:58:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pajou-00020F-SQ for pgsql-hackers@lists.postgresql.org; Fri, 10 Mar 2023 20:58:32 +0000 Received: from sender4-op-o10.zoho.com ([136.143.188.10]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pajos-0005gx-BI for pgsql-hackers@postgresql.org; Fri, 10 Mar 2023 20:58:31 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1678481904; cv=none; d=zohomail.com; s=zohoarc; b=ZCqv7qksYk6o25NylRW3AZGrCtLaJLREELXoyNx6BE0kvMvFVTo97hdzutjdETz2We7HQ4MzvclX+kTo0x26E8/j7haVPJY/YpwATLqUolIcQeCKGAJNzGCvSsaEA3UpLNLmyYDoYoWOJPVM2H+PRfXFp9Y5l2o8azU//7gdgNo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678481904; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=sszhsOGhk/yJ4vcHt89dDv5RFHORcRP1ZArxcGyXD3I=; b=QWYbyti2S6I3/6nVDmy7PNV+O+cwAgqeLfEeTlG/up52B/d8QQJNmfW2hF7DC13XWJG9qeshokwdfDbu+pvOv6581/9Cu0Sc8KpzWqUvpRuU92aXvm0ekqjY3mFkhmVorDKAilM8LaJLi4SDAlCvSdyGbZHJzRMn0GmahFWR77A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=highgo.ca; spf=pass smtp.mailfrom=david.zhang@highgo.ca; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1678481904; s=zoho; d=highgo.ca; i=david.zhang@highgo.ca; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=sszhsOGhk/yJ4vcHt89dDv5RFHORcRP1ZArxcGyXD3I=; b=NTwm9WhE121yS8qpQkBv93tB0gtt7TwR8MJ9ZoMmQt3VtfOZAqnRvNNrGLqsZ1fD lCwUMrqle0fGO1G3WOBt74O66JG73YiOtfK6ZZN5vN+EKkYaZplpd2f7JTqwqbo5EvK 6onR0QbrGITvZzLIk4R59VimYa56l81IGDA2YOzM= Received: from [192.168.1.88] (d66-183-207-156.bchsia.telus.net [66.183.207.156]) by mx.zohomail.com with SMTPS id 1678481903801186.598262526555; Fri, 10 Mar 2023 12:58:23 -0800 (PST) Message-ID: <3499c5ed-5511-0801-ccfe-297b098aa8fe@highgo.ca> Date: Fri, 10 Mar 2023 12:58:23 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [BUG] pg_stat_statements and extended query protocol Content-Language: en-US To: "Imseih (AWS), Sami" , Michael Paquier Cc: "pgsql-hackers@postgresql.org" References: <9B9BB0F2-68A3-44E0-946E-3D9051F83369@amazon.com> From: David Zhang In-Reply-To: <9B9BB0F2-68A3-44E0-946E-3D9051F83369@amazon.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > Yes, I agree that proper test coverage is needed here. Will think > about how to accomplish this. Tried to apply this patch to current master branch and the build was ok, however it crashed during initdb with a message like below. "performing post-bootstrap initialization ... Segmentation fault (core dumped)" If I remove this patch and recompile again, then "initdb -D $PGDATA" works. Thanks, David