public inbox for [email protected]
help / color / mirror / Atom feedFrom: Chao Li <[email protected]>
To: John Naylor <[email protected]>
Cc: li carol <[email protected]>
Cc: albert tan <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: Correct comment wording in extension.c
Date: Tue, 13 Jan 2026 14:31:55 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CANWCAZaqNd3Lc8YumUE05A-ybxB4dUCXT7dOP7Fr-+drBrR5kA@mail.gmail.com>
References: <CAEzortnJB7aue6miGT_xU2KLb3okoKgkBe4EzJ6yJ=Y8LMB7gw@mail.gmail.com>
<CANWCAZYgLtgwKFvwe+sGaN-r8-65DxnQctREuk=VDLbfg=X4XA@mail.gmail.com>
<CAEzortkOoNDpoQgqTFtCYsf6u_D5O39gqnDeFiV4V5JDTPEdyw@mail.gmail.com>
<KL1PR01MB6662DF8D45EB58001065FB458182A@KL1PR01MB6662.apcprd01.prod.exchangelabs.com>
<CANWCAZbGH-7GpX3U5Ea=TBa5NNBo0MKoaeiOiFHv=jsbUXf3Ag@mail.gmail.com>
<CAEoWx2k2JZXbzhNRApacT7F1UYJ8tqC-k3t5gLHe7ky_-XtuoQ@mail.gmail.com>
<CANWCAZaqNd3Lc8YumUE05A-ybxB4dUCXT7dOP7Fr-+drBrR5kA@mail.gmail.com>
> On Jan 13, 2026, at 13:40, John Naylor <[email protected]> wrote:
>
> On Sun, Jan 11, 2026 at 11:58 AM Chao Li <[email protected]> wrote:
>> v4-0001 looks good to me.
>
> When I say I'm going to commit "unless/barring", no response is
> necessary unless there is a problem.
>
>> I just went through extension.c and got a few more comment improvements. I put them in v5-0002, please take a look.
>
> - * for them therefore uses about O(N^2) time when there are N versions of
> + * for them therefore uses O(N^2) time when there are N versions of
>
> - /* store the OID of the namespace to-be-changed */
> + /* store the OID of the namespace to be changed */
>
> Please read these responses to you from last week:
>
> https://www.postgresql.org/message-id/1909358.1767854695%40sss.pgh.pa.us
> https://www.postgresql.org/message-id/7k27ut6kugt2mizo5cy5wplbbrz4ccbkxvsc2iqu5yde344iya%40dxktdjw6u...
>
> I've pushed v4.
>
Sure, I have read them carefully.
But you really missed:
```
diff --git a/src/backend/commands/extension.c b/src/backend/commands/extension.c
index 596105ee078..a9529692ae3 100644
--- a/src/backend/commands/extension.c
+++ b/src/backend/commands/extension.c
@@ -2398,7 +2398,7 @@ pg_available_extension_versions(PG_FUNCTION_ARGS)
/*
* Ignore already-found names. They are not reachable by the
- * path search, so don't shown them.
+ * path search, so don't show them.
*/
extname_str = makeString(extname);
if (list_member(found_ext, extname_str))
```
This is not the one in v4.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Correct comment wording in extension.c
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox