Feedback-ID: ie0a040ee:Fastmail
Message-ID: <34bfa53d-671d-4592-8d7a-26e51c3ed45e@eisentraut.org>
Date: Tue, 13 Feb 2024 07:53:57 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: make dist using git archive
Content-Language: en-US
To: Tristan Partin <tristan@neon.tech>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
References: <40e80f77-a294-4f29-a16f-e21bc7bc75fc@eisentraut.org>
 <CYLI6IZ5RAVR.3RBBF4F3P8MHX@neon.tech>
 <673bbcc2-3e38-44b6-9710-e7c1b2446334@eisentraut.org>
 <CYNXE6A4IB2S.V1YYOX54IVJ@neon.tech>
 <dbff5b4f-21a9-4340-82ee-884b13ee6a3d@eisentraut.org>
 <ac794e4f-28a5-410a-91ec-a7de31de7dc8@eisentraut.org>
 <CZ39YV3UPPVQ.2BAG10HIX2KFU@neon.tech>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CZ39YV3UPPVQ.2BAG10HIX2KFU@neon.tech>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/34bfa53d-671d-4592-8d7a-26e51c3ed45e%40eisentraut.org>
Precedence: bulk

On 12.02.24 18:26, Tristan Partin wrote:
> On Sun Feb 11, 2024 at 5:09 PM CST, Peter Eisentraut wrote:
>> Small update: I noticed that on Windows (at least the one that is 
>> running the CI job), I need to use git -c core.autocrlf=false, 
>> otherwise git archive does line-ending conversion for the files it 
>> puts into the archive.  With this fix, all the archives produced by 
>> all the CI jobs across the different platforms match, except the 
>> .tar.gz archive from the Linux job, which I suspect suffers from an 
>> old git version.  We should get the Linux images updated to a newer 
>> Debian version soon anyway, so I think that issue will go away.
> 
> I think with this change, it is unlikely I will be able to upstream 
> anything to Meson that would benefit Postgres here since setting this 
> option seems project dependent.

Meson is vulnerable to the same problem: If the person who makes the 
release had some crlf-related git setting activated in their 
environment, then that would affect the tarball.  And such a tarball 
would be genuinely broken for non-Windows users, because at least some 
parts of Unix systems can't process such CRLF files correctly.

(This is easy to test: Run meson dist with core.autocrlf=true on the 
postgresql tree on a non-Windows system.  It will fail during dist check.)