public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: jian he <[email protected]>
To: Zsolt Parragi <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Rebuild CHECK constraints after generated column SET EXPRESSION
Date: Wed, 8 Jul 2026 20:15:54 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACJufxFG+vn8vdHAedGuqwb9iC58HHPGSEaLwm6_Tcv-3AyH=w@mail.gmail.com>
References: <CAJTYsWXOkyeDVbzymWc9sKrq7Y_MUv6XJXN4H9GfsBOPd3NJ+w@mail.gmail.com>
	<CACJufxE3e1jPsKLsjNWMucahFJW7UO_UGWzhRESRvJ+8PeKgkg@mail.gmail.com>
	<CAJTYsWX+g49jMArk0MdS0+suEY8CckyAYpm+KvNLU9Zx9=6t3g@mail.gmail.com>
	<CACJufxGPNgAcQEiwD0QFCTP8vi0XZzys06EEQUnR84_0Qo9s9Q@mail.gmail.com>
	<CAJTYsWUooEDFaNOiOLjz0NqmqBtof65b-sQQHWmh8jV9t-VYEA@mail.gmail.com>
	<CACJufxGBSeAcyStRHajNvqerGCRGB5Wb=e5cbGd7HFT4=aMsLw@mail.gmail.com>
	<CAJTYsWWw7s0N2hnAW9pfhkSx-aN=wELErrBEicoPMnmmS1e7kg@mail.gmail.com>
	<CACJufxGdr-A7hwBRWh02YHbb13M-LG3bAOad+86iivp2008tTA@mail.gmail.com>
	<CAN4CZFMHmb=o_GkJrgEY1iEQpnuDtL_YEHKFZNWG0bdZyozXvA@mail.gmail.com>
	<CACJufxFG+vn8vdHAedGuqwb9iC58HHPGSEaLwm6_Tcv-3AyH=w@mail.gmail.com>

On 02.06.26 02:41, jian he wrote:
> On Fri, May 29, 2026 at 6:58 AM Zsolt Parragi <[email protected]> wrote:
>>
>> Looks good, I have one nitpick question:
>>
>> +                       if (isnull)
>> +                               elog(WARNING, "null conbin for relation \"%s\"",
>> +                                        RelationGetRelationName(rel));
>>
>> Shouldn't this be an error instead? Most existing checks treat it as
>> an error, and that seems better to me as this shouldn't happen
>> normally?
>>
> OK.
> 
> I changed it to:
>> +                       if (isnull)
>> +                               elog(ERROR, "null conbin for relation \"%s\"",
>> +                                        RelationGetRelationName(rel));
> 
> I also slightly rephrased the commit message.

Committed with some code beautification editorialization.

view thread (6+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Rebuild CHECK constraints after generated column SET EXPRESSION
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox