Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oCSmp-0007JR-G7
	for pgsql-hackers@arkaria.postgresql.org; Fri, 15 Jul 2022 21:23:47 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1oCSmo-0006W6-6I
	for pgsql-hackers@arkaria.postgresql.org; Fri, 15 Jul 2022 21:23:46 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oCSmn-0006Vx-TZ
	for pgsql-hackers@lists.postgresql.org; Fri, 15 Jul 2022 21:23:45 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1oCSml-00081h-Qa
	for pgsql-hackers@postgresql.org; Fri, 15 Jul 2022 21:23:44 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 26FLNeOH3501998;
	Fri, 15 Jul 2022 17:23:40 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Jacob Champion <jchampion@timescale.com>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Log details for client certificate failures
In-reply-to: <20220715211914.c5oasfknx2njndov@awork3.anarazel.de>
References: <2ef20161-e99d-a6ea-a36d-577843a2daae@enterprisedb.com>
 <CAAWbhmiQVSAc_rOdW8q9R3GJehxkmaW5-CMbYLgrCjhotSs8Bg@mail.gmail.com>
 <49b48719-d6cf-9e03-fab3-e4505cf9d585@enterprisedb.com>
 <CAAWbhmhbM5zwjjVsYkhTOFrV308iFbsGceWiseSbFPQeq24Fww@mail.gmail.com>
 <059e67f5-3769-24c8-f460-4e5d87af529a@enterprisedb.com>
 <0167a8c5-1754-9121-b994-0719a6493a21@timescale.com>
 <20220715191156.jecddreykoakdljm@awork3.anarazel.de>
 <ca6eb74e-aafc-f7cc-50fd-a6b33bca858b@timescale.com>
 <20220715203500.vanqxt23bmufjais@awork3.anarazel.de>
 <2878aee8-a4a6-8078-9740-efe90fcf8328@timescale.com>
 <20220715211914.c5oasfknx2njndov@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Fri, 15 Jul 2022 14:19:14 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3501996.1657920220.1@sss.pgh.pa.us>
Date: Fri, 15 Jul 2022 17:23:40 -0400
Message-ID: <3501997.1657920220@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/3501997.1657920220%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> We already have pg_clean_ascii() and use it for application_name, fwiw.

Yeah, we should just use that.  If anyone wants to upgrade the situation
for non-ASCII data later, fixing it for all of these cases at once would
be appropriate.

			regards, tom lane